HomePhabricator

Fix tabs and jQuery 1.9 compatibility

Authored by Mattflaschen-Personal on Jun 29 2014, 5:36 AM.

Description

Fix tabs and jQuery 1.9 compatibility

  • Replace .toggle( max, min ) (deprecated); minor tweaks to showHideButton element
  • Use jQuery UI collapsible support, rather than manual show/hide, which was causing bugs; rename tabs element.
  • Use beforeActivate instead of show so there's no flash
  • Replace events for clicks on tab links with handling in beforeActivate. Also move logic to update up/down show/hide button here, required for consistent state.
  • Change terminology to match jQuery UI Tabs.
  • Refactor template/dummy element creation to keep tabs element clean.

Fixes issue #187 and issue #189.

Details

Committed
Mattflaschen-PersonalJun 29 2014, 8:33 PM
Parents
rWGPIbcce3c824785: Use custom link for filing issue so questions are pre-filled
Branches
Unknown
Tags
Unknown
ChangeId
None