HomePhabricator

Fix x axis in line graph

Authored by fdans on Sep 22 2017, 2:24 PM.

Description

Fix x axis in line graph

Summary:
Ref T175265

Until now the x axis was broken for daily granularities and padding and label rotation were outdated, since the changes pushed recently only fixed the bar graph. We should really unify as much logic as possible between the bar chart and the line chart to avoid having to repeat work.

Test Plan: In the detail page, with a line graph, switch to 1-month or 3-month time ranges. The space between the labels in the x axis should be uniform and there should be on overlap between them.

Reviewers: mforns

Reviewed By: mforns

Subscribers: fdans

Maniphest Tasks: T175265

Differential Revision: https://phabricator.wikimedia.org/D788

Details

Auditors
Milimetric
Committed
fdansSep 22 2017, 2:25 PM
Reviewer
mforns
Differential Revision
D788: Fix x axis in line graph
Parents
rWIKISTATS269cab375dfc: don't know why rangeround was replaced by range
Branches
Unknown
Tags
Unknown
Tasks
T175265: Productionise list view
ChangeId
None
Build Status
Buildable 2268
Build 3670: ci-jessieJenkins

Event Timeline

Milimetric accepted this commit.Sep 29 2017, 8:32 PM
Milimetric added a subscriber: Milimetric.

Limn was all about unifying all graph rendering - be careful going down that road, there are dragons. We can generalize a few things, though.

All concerns with this commit have now been addressed.Sep 29 2017, 8:32 PM