Page MenuHomePhabricator
Search Advanced Search
Use the application-specific Advanced Search to set additional search criteria: Tasks, Commits. (More information)
    • Task
    We should reduce differences between PHP and JS code-comment documentation. There is a handy script in the repository, `bin/doccomparer.rb`, which generates the following report: (as of 2017-04-07) {P5225} There are 358 "MISMATCH"-es right now. Ideally, there would be zero. But let's say we can close this task when we have… fewer than 50? Usually, these need to be simply fixed in PHP or JS – many are trivial like different capitalisation or missing full stop. Sometimes it's a pattern of differences that should be ignored, by adding it to the 'sanitize_description' method in doccomparer.rb. Various items are also missing in JS or PHP only. "PHP missing" is usually okay (many methods and options are indeed simply not implemented in PHP). "JS missing" is usually not okay (most cases are instances of {T88629}).