Page MenuHomePhabricator
Search Advanced Search
Use the application-specific Advanced Search to set additional search criteria: Tasks, Commits. (More information)
    • Task
    **Feature summary** (what you would like to be able to do and where): * WikiLove should parse and include the contents of https://en.wikipedia.org/wiki/Wikipedia:Barnstars. That page has a large collection of good barnstars and the code needed to place them. Could be done in JavaScript so as not to slow down the loading of everything else. If that page isn't present on that wiki, it doesn't parse it. If the page is present, it adds a new category at the bottom of the "Select type" area. **Use case(s)** (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution): **Benefits** (why should this be implemented?): * More cool barnstars :)
    • Task
    Open console from the recent changes page in "live updates" mode. "wikipage.content hook should not be fired on unattached content" warning is shown.
    • Task
    **Steps to replicate the issue** (include links if applicable): * Open the WikiLove panel * Select the "Barnstars" type on the left * Quickly and repeatedly change the "Select a barnstar" dropdown (maybe using browser devtools to simulate slower internet speeds) This isn't 100% reproducible, unfortunately. It seems to be race condition when calling `showImagePreview()` over and over in quick succession. **What happens?**: You see two previews of the image in the `.mw-wikilove-image-preview-content` element. Upon submission, you'll see some nasty errors in the WikiLove dialog to the effect of "something went wrong", but it still actually works and successfully reloads the page with the talk page message posted. **What should have happened instead?**: It should only ever show one image preview, and no errors should be shown upon submission. **Software version** (skip for WMF-hosted wikis like Wikipedia): MW 1.41.0 @ `c790c9915ca`; WikiLove at `538aa1e` (after [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLove/+/921374 | r921374 ]]), but possibly older versions, too. **Other information** (browser name/version, screenshots, etc.): Observed in Firefox 112 and Chrome 113
    • Task
    **Steps to replicate the issue** (include links if applicable): * Download Wikilove and have this configuration in your local.php ```wfLoadExtension( 'WikiLove' );``` ```$wgDefaultUserOptions['wikilove-enabled'] = 1; ``` * If you don't have a temp user, create one in Local * Change skin to Minerva and add the temp user into the URL ex. http://localhost:8080/wiki/User:*Unregistered_28) **What happens?**: Wikilove icon should appear to choose from under the Minerva skin **What should have happened instead?**: Wikilove icon does not appear under the Minerva skin **Other information** (browser name/version, screenshots, etc.): | **Skins** | **Wikilove Results** | **Vector 2022** | {F36998491} | **Vector 2010** | {F36998494} | **Minerva** | {F36998502} | **Monobook** | {F36998498} | **Timeless** | {F36998500} Related to: https://phabricator.wikimedia.org/T335844
    • Task
    ####Summary We should stop collecting any unnecessary WikiLove data {T62984}, then complete this task to update legal terms. ####User story As a community member, I don't think the current Wikilove logging is needed, and we should complete T62984 and update the terms / legal disclaimer. As WMF Legal, I want to limit data collection and only retaining user data for the shortest possible time that is consistent with maintaining, understanding, and improving the Wikimedia Sites, and our obligations under applicable law. As WMF Product, I want the legal disclaimer to be more consistent with what editors see through other editing / discussion pathways. ---- Note from @Legoktm: I'm pretty sure no one is actively working on WikiLove these days, so we should stop collecting any extra private data (related: {T62984}) and remove the extra legal boilerplate. We have a revision tag now, so anyone can perform analysis using purely public data that shouldn't require any extra legal statements to scare people away from sending WikiLove. ---- ####Design: **Current design:** {F36869561} **Updated design:** Design TBD. Text size and layout should be in alignment with DiscussionTools UI: {F36885371} **Current language: ** >By submitting, you agree to transparency under these [[ https://foundation.wikimedia.org/wiki/Legal:Feedback_privacy_statement | terms ]]. **Updated Legal Terms** >By clicking "Send WikiLove", you agree to the [[ https://foundation.wikimedia.org/wiki/Terms_of_Use/en | Terms of Use ]], and you irrevocably agree to release your contribution under the [[ https://en.wikipedia.org/wiki/Wikipedia:Text_of_the_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License | CC BY-SA 3.0 License ]] and the [[ https://en.wikipedia.org/wiki/Wikipedia:Text_of_the_GNU_Free_Documentation_License | GFDL ]]. You agree that a hyperlink or URL is sufficient attribution under the Creative Commons license. ---- ####Acceptance Criteria: Given T62984 is completed, When I'm viewing the Wikilove dialog, Then I see the updated legal terms near the Send WikiLove button
    • Task
    * [ ] replace `.button()` in 39 spots * [ ] replace `.draggable()` in 1 spot * [ ] turn off jquery.ui in PageTriage in a localhost environment and see if anything else breaks. identify and fix breakages Motivation: jquery.ui is maintained upstream, but MediaWiki has marked it as deprecated [[ https://gerrit.wikimedia.org/r/c/mediawiki/core/+/386727 | since 2017 ]] because they want to reduce the amount of libraries/bandwidth being loaded on the front end Converting PageTriage to Codex (T208256) is a big project that would probably change the front end a lot, so may not have consensus and the work may not happen. So this ticket is an intermediate step. If there's a way to get rid of jquery.ui without changing the front end appearance of PageTriage significantly and without creating a lot of work, we should move forward with that. Perhaps we can use a `.button()` from one of our supported libraries.
    • Task
    **List of steps to reproduce** (step by step, including full links if applicable): * Open wikilove dialog on https://commons.wikimedia.beta.wmflabs.org/wiki/User_talk:AJ-test * Select kittens or goats **What happens?**: * Kittens: one image loads (because I uploaded it), infinite mw-wikilove-spinner because the others are missing * Goats: infinite mw-wikilove-spinner. Now select kittens: the one kitten image that is available won't load. **What should have happened instead?**: If any images did load, just hide the spinner. If no images loaded, present an error like "This wiki has no images available for this type." After switching from goats to kittens, the one available kitten image should have loaded.
    • Task
    Right now the tab still shows even without JavaScript in the Monobook skin, but doesn't do anything when clicked. This breaks MediaWiki's commitment to unobtrusive JavaScript. Use JavaScript to add tab, so users with it disabled don't have the nonfunctional tab
    • Task
    Once we've switched from the migration build of Vue 3 to the regular build of Vue 3, the `compatConfig` settings in component definitions will be ignored, and we should remove them. Code search: https://codesearch.wmcloud.org/search/?q=compatConfig&i=nope&files=&excludeFiles=&repos= In addition, we should remove (conditional) calls to `Vue.configureCompat`. Some repos erroneously use `configureCompat` as a component setting instead of `compatConfig`, so we should remove those as well. Code search: https://codesearch.wmcloud.org/search/?q=configureCompat&files=&excludeFiles=&repos=
    • Task
    **Steps to reproduce:** **on Flow pages (reproducible in betalabs)** # Open WikiLove (click heart icon) and pick a kitty to send. Type a message. # Use the X in the corner of the box to close it. # Open WikiLove again (click heart icon again). # Preview. # Send. **Actual results:** Two identical messages posted. **Expected results:** One message sent. **Extra fun:** Double-click the Send button in step 5. Then you can send four kitties. On wikitext User talk pages, the steps are as above, but the Send button **must ** be double-clicked.
    • Task
    MacOS 10.12.6 (16G1212) Chrome Version 64.0.3282.186 (Official Build) (64-bit) Also reproducible with Safari Version 11.0.3 (12604.5.6.1.1) When the window isn't wide enough to fit all the tabs, some of the tabs get merged in a weird way. See the left pane in the attached screenshot. The right pane is exactly the same page, but with the window stretched wider so all the tabs fit. When I check "Temporarily disable the visual editor while it is in beta" under Special:Preferences#mw-prefsection-editing, I can't reproduce the problem. {F15273054}
    • Task
    As [[https://en.wikipedia.org/wiki/Wikipedia_talk:WikiLove/Archive_1#Strange_behaviour_by_WikiLove?|suggested]]: > the wikitext emitted from the WikiLove tool should have a comment in it to say it was produced by the WikiLove tool with some suitable link, so it educates people to use the tool I.e. WikiLove should automatically add a hidden comment after the user's signature, such as: `<!-- message sent using the WikiLove tool. Click the ♥ at the top of userpages to send WikiLove. -->` or similar.
    • Task
    See https://www.mediawiki.org/wiki/User_talk:IKhitron I clicked once. Based on testing at https://www.mediawiki.org/wiki/User_talk:Quiddity_(WMF)#A_barnstar_for_you.21 the **steps to reproduce** might be: # Go to Quiddity's talk page on mw.org # Open Wikilove. Choose a barnstar from the drop-down menu. # Press Esc to cancel. (Go do something else, e.g., scroll down the page or open a link in another tab.) (If you skip this step, then Wikilove works normally.) # Open Wikilove again. Choose a barnstar from the drop-down menu. # Press Esc to cancel. (Go do something else, e.g., scroll down the page or open a link in another tab.) # Open Wikilove a third time. Choose a barnstar (maybe needs to be the same as the first one?) from the drop-down menu. # Fill in the box. # Send Wikilove. # See two identical barnstars on the page. # Refresh the page. # See three identical barnstars on the page. I've only tested this in Flow.
    • Task
    Port it to use the server-side MessagePoster interface in core
    • Task
    When posting a Wikilove message to a usertalkpage that uses Flow, the preview shows a signature, but the signature is actually removed (purposefully, because signatures are not needed/used in Flow posts). Ideally, the preview would not show the signature, if the page is using the Flow content model. {F1297105}
    • Task
    The WikiLove extension makes an internal API request (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLove/+/refs/heads/master/includes/ApiWikiLove.php#73) and then later manually calls `ChangeTags::addTags` to add the "wikilove" tag. Instead it should use the `tags=` parameter for the API (as the code already supports) to add the change tag.
    • Task
    Duplicate section headings make pages hard to edit and navigate. Please find a system that reduces the number of == A barnstar for you! == section headings. My three ideas are: == An Original Barnstar for you! == == A barnstar for you! (August 2014) == == A custom section heading for you! == The last would use the same form as "Make your own", pre-populated with the default section heading. This way it would be easy to change it if you wanted to. -------------------------- **Version**: unspecified **Severity**: enhancement
    • Task
    WikiLove logs actions to a custom database, for analytics purposes. This was before we had EventLogging infrastructure. Since we now do have EventLogging infrastructure, we should migrate to that and ditch the database. -------------------------- **Version**: unspecified **Severity**: enhancement
    • Task
    At https://www.mediawiki.org/wiki/Thread:User_talk:Peachey88/A_kitten_for_you! WikiLove added a signature in the message itself even though LQT adds in a signature at the bottom of the message. Somewhere in the WikiLove javascript, a request is made to action=wikilove, and the text parameter of that request already has ~~~~ in it. We can either have that portion of JS check whether we're on a LQT enabled page, or postpone adding the signature in the PHP portion, and add it if we're not on LQT. -------------------------- **Version**: unspecified **Severity**: normal **URL**: https://www.mediawiki.org/wiki/Thread:User_talk:Peachey88/A_kitten_for_you!
    • Task
    It'd be nice if WikiLove had a javascripty autocomplete for image names (at least local ones) -------------------------- **Version**: master **Severity**: enhancement
    • Task
    Wikilove places messages in interface language of the user who using wikilove to pass appreciation. It should either be in wiki language or be like other interface messages (switch languages per user.) https://commons.wikimedia.org/w/index.php?title=User_talk%3ARas67&diff=102879216&oldid=102817340 -------------------------- **Version**: unspecified **Severity**: normal
    • Task
    The WikiLove heart icon is currently solid red. It sits next to the watch star icon, which is transparent with a blue border until a user clicks the star icon (i.e., watches a page), in which case the star icon becomes solid blue. It's a bit strange that the heart icon appears to indicate that you've already doled out wikilove to the user by being solid red, particularly when it's juxtaposed with the "empty" (transparent) star icon. Perhaps the icon should use a red border instead. -------------------------- **Version**: unspecified **Severity**: trivial
    • Task
    Many people who don't know JavaScript would like to add customized WikiLove awards, but customizing WikiLove awards requires editing cryptic JavaScript pages. It also requires sysop rights, even though it is not needed for the classic barnstars. It would be nice to have an interface through which all users would be able to edit awards without having to know programming. -------------------------- **Version**: unspecified **Severity**: enhancement
    • Task
    **Author:** `eggcentricwiki` **Description:** Since wikilove is making edits to other users' talk pages, I think there ought to be an "add to watchlist" checkbox, much as there is if one were making the edit entirely manually. I should imagine this will take about 20 minutes, if that, to implement. -------------------------- **Version**: unspecified **Severity**: enhancement