Change Details

This important bi-daily cleanup script is pretty much unmonitored and hard to manually test. Any bugs in it that take down the entire script (such as T331412) will likely not be discovered until a couple months later when a developer finally notices the various PageTriage queues are not getting cleaned out. Suggested strategy - extend PageTriageTestCase, which extends IntegrationTestCase - look at /tests/phpunit/MaintenancePopulateDraftQueueTest.php for inspiration. that is a similar integration test of a maintenance script - use `$this->setMwGlobals()` to set as many globals as needed to match enwiki

This important bi-daily cleanup script is pretty much unmonitored and hard to manually test. Any bugs in it that take down the entire script (such as T331412) will likely not be discovered until a couple months later when a developer finally notices the various PageTriage queues are not getting cleaned out. Suggested strategy - extend PageTriageTestCase, which extends IntegrationTestCase - look at /tests/phpunit/MaintenancePopulateDraftQueueTest.php for inspiration. that is a similar integration test of a maintenance script - use `$this->setMwGlobals()` to set as many globals as needed to match enwiki This would also make refactoring and bug fixing in this file safer. For example, T321982

This important bi-daily cleanup script is pretty much unmonitored and hard to manually test. Any bugs in it that take down the entire script (such as T331412) will likely not be discovered until a couple months later when a developer finally notices the various PageTriage queues are not getting cleaned out. Suggested strategy - extend PageTriageTestCase, which extends IntegrationTestCase - look at /tests/phpunit/MaintenancePopulateDraftQueueTest.php for inspiration. that is a similar integration test of a maintenance script - use `$this->setMwGlobals()` to set as many globals as needed to match enwiki This would also make refactoring and bug fixing in this file safer. For example, T321982