Change Details

## Background * Tideways has abandoned [php-tideways_xhprof](https://github.com/tideways/php-xhprof-extension/) in 2023. * Debian has removed [php-tideways](https://packages.debian.org/oldstable/php-tideways) from testing (it is still in stable, but won't be in the next LTS). * A few years ago, Wikimedia adopted tideways_xhprof because the original xhprof from Phacility lacked PHP8 support, which Tideways added to their fork. Another fork (which also supports PHP8) has been rewarded the original name and is now continuing the work. * Wikimedia is now switching to the latest version of the original xhprof package (for both PHP 8.1 and the upcoming PHP 8.3 upgrade, per T398245#11031778). * [mw:MediaWiki-Docker/Configuration recipes/Profiling](https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/Profiling) says "//MediaWiki-Docker comes with php-tideways pre-installed.//", but it the latest php8.3 images do not actually install this. This was apparently removed in 2023 (T338208#8992016, [commit](https://gitlab.wikimedia.org/repos/releng/dev-images/-/commit/efbc950462449fa293653bf0129423273664e8d3)) >>! @Krinkle wrote at {T400109}: > […] MediaWiki core supports php-xhprof 0.9 and its fork php-tideways_xhprof. The current version of php-xhprof is 2.x, which we have not tested before. As part of the PHP 8.1 to PHP 8.3 upgrade, we will be switching from the abandoned php-tideways-xhprof package to the php-xhprof 2.x package. I wrote more details and reasons for this package choice at T398245#10965108. […] >>! In T400109#11057424, @Krinkle wrote: > I've updated the install instructions at <https://www.mediawiki.org/wiki/Manual:Profiling> to recommend XHProf instead of Tideways going forward, covering various installation methods and distributions. ## Scope Sury provides php-xhprof packages for all PHP versions. For php8.1 and php8.3, I imagine we'll want to switch from Sury to WMF (as for php7.2 and php7.4 previously), but if that is non-trivial, consider it out of scope for this task. * [ ] Ensure php8.1, php8.2, and php8.3+ images have php-xhprof preinstalled. * [ ] Update MediaWiki core's docker-compose.yaml to use versions of the images that have php-xhprof installed.

## Background * Tideways has abandoned [php-tideways_xhprof](https://github.com/tideways/php-xhprof-extension/) in 2023. * Debian has removed [php-tideways](https://packages.debian.org/oldstable/php-tideways) from testing (it is still in stable, but won't be in the next LTS). * A few years ago, Wikimedia adopted tideways_xhprof because the original xhprof from Phacility lacked PHP8 support, which Tideways added to their fork. Another fork (which also supports PHP8) has been rewarded the original name and is now continuing the work. * Wikimedia is now switching to the latest version of the original xhprof package (for both PHP 8.1 and the upcoming PHP 8.3 upgrade, per T398245#11031778). * php-tideways_xhprof was added to MediaWiki-Docker in 2020. {T246202} * [mw:MediaWiki-Docker/Configuration recipes/Profiling](https://www.mediawiki.org/wiki/MediaWiki-Docker/Configuration_recipes/Profiling) says "//MediaWiki-Docker comes with php-tideways pre-installed.//", but it the latest php8.3 images do not actually install this. This was apparently removed in 2023 (T338208#8992016, [commit](https://gitlab.wikimedia.org/repos/releng/dev-images/-/commit/efbc950462449fa293653bf0129423273664e8d3)) >>! @Krinkle wrote at {T400109}: > […] MediaWiki core supports php-xhprof 0.9 and its fork php-tideways_xhprof. The current version of php-xhprof is 2.x, which we have not tested before. As part of the PHP 8.1 to PHP 8.3 upgrade, we will be switching from the abandoned php-tideways-xhprof package to the php-xhprof 2.x package. I wrote more details and reasons for this package choice at T398245#10965108. […] >>! In T400109#11057424, @Krinkle wrote: > I've updated the install instructions at <https://www.mediawiki.org/wiki/Manual:Profiling> to recommend XHProf instead of Tideways going forward, covering various installation methods and distributions. ## Scope Sury provides php-xhprof packages for all PHP versions. For php8.1 and php8.3, I imagine we'll want to switch from Sury to WMF (as for php7.2 and php7.4 previously), but if that is non-trivial, consider it out of scope for this task. * [ ] Ensure php8.1, php8.2, and php8.3+ images have php-xhprof preinstalled. * [ ] Update MediaWiki core's docker-compose.yaml to use versions of the images that have php-xhprof installed.