Change Details

This is a follow up to the conversation at https://gerrit.wikimedia.org/r/#/c/323337/4/includes/models/MobileCollection.php. Basically, MF PHP codebase has a use case where it would be more efficient to check for emptiness of a collection rather than counting its elements and comparing it to 0. ==A/C== [] Create a new interface with one method only, e.g. isEmpty, to check for emptiness of an object. [] The interface should live in MF for now and then be upstreamed to core if need be. [] Audit the MF codebase and replace the use of `count( $object ) === 0` with `isEmpty( $object )` where needed.

This is a follow up to the conversation at https://gerrit.wikimedia.org/r/#/c/323337/4/includes/models/MobileCollection.php. Basically, MF PHP codebase has a use case where it would be more efficient to check for emptiness of a collection rather than counting its elements and comparing it to 0. ==A/C== [] Create a new interface with one method only, e.g. isEmpty, to check for emptiness of a collection object. [] The interface should live in MF for now and then be upstreamed to core if need be. [] Audit the MF codebase and replace the use of `count( $object ) === 0` with `$collectionObjectInstance->isEmpty()` where needed.

This is a follow up to the conversation at https://gerrit.wikimedia.org/r/#/c/323337/4/includes/models/MobileCollection.php. Basically, MF PHP codebase has a use case where it would be more efficient to check for emptiness of a collection rather than counting its elements and comparing it to 0. ==A/C== [] Create a new interface with one method only, e.g. isEmpty, to check for emptiness of a collection object. [] The interface should live in MF for now and then be upstreamed to core if need be. [] Audit the MF codebase and replace the use of `count( $object ) === 0` with `isEmpty( $object `$collectionObjectInstance->isEmpty()` where needed.