Change Details

Puppet fails on CI slaves with: ``` Notice: /Stage[main]/Ganglia::Monitor::Packages/File[/etc/ganglia/conf.d]/ensure: created Error: Cannot create /usr/lib/ganglia/python_modules; parent directory /usr/lib/ganglia does not exist ``` That is because ganglia is no more installed, though on old instances `/etc/ganglia` is still around. The root cause is that the browser tests virtual host uses `apache::site`` which ends up including `apache::monitoring` which include ganglia ... Looks like we can short circuit it via `$::standard::has_ganglia`.

Puppet fails on CI slaves with: ``` Notice: /Stage[main]/Ganglia::Monitor::Packages/File[/etc/ganglia/conf.d]/ensure: created Error: Cannot create /usr/lib/ganglia/python_modules; parent directory /usr/lib/ganglia does not exist ``` That is because ganglia is no more installed, though on old instances `/etc/ganglia` is still around. The root cause is that the browser tests virtual host uses `apache::site`` which ends up including `apache::monitoring` which include ganglia ... Same goes with `hhvm::monitoring` Looks like we can short circuit it via `$::standard::has_ganglia`.

Puppet fails on CI slaves with: ``` Notice: /Stage[main]/Ganglia::Monitor::Packages/File[/etc/ganglia/conf.d]/ensure: created Error: Cannot create /usr/lib/ganglia/python_modules; parent directory /usr/lib/ganglia does not exist ``` That is because ganglia is no more installed, though on old instances `/etc/ganglia` is still around. The root cause is that the browser tests virtual host uses `apache::site`` which ends up including `apache::monitoring` which include ganglia ... Same goes with `hhvm::monitoring` Looks like we can short circuit it via `$::standard::has_ganglia`.