**Background information**
Some files, e.g. https://commons.wikimedia.org/wiki/File:Sarajevo_Cathedral_Rose_Window.jpg, have a `copyright licence = attribution only license` statement.
That's https://www.wikidata.org/wiki/Q98923445 on wikidata.
We allow filtering based on licenses with special search keyword. They can either be:
- haslicense:cc-by-sa
- haslicense:cc-by
- haslicense:unrestricted
- haslicense:other (for whetever does have a license, but didn't fit above)
The Special:MediaSeach UI, however, hides this search keyword complexity behind a simple filter with these options
- Use with attribution
- Use with attribution and same license
- No restrictions
- Other
AFAICT, the "attribution only license" statement in question is not a creative commons license.
Logically, I'd expect it belongs under "Use with attribution" in our UI, but given that it's not a CC license, it probably doesn't belong under "haslicense:cc-by-sa" (which is what drives the results for the "Use with attribution" option.
There's a minor disconnect between the search license keyword option names, and how we describe them in the UI. This causes some licenses to not fit within our model.
Acceptance criteria:
[] `cc-by` must be renamed to `attribution` in https://commons.wikimedia.org/wiki/MediaWiki:Wikibasecirrus-license-mapping
[] `cc-by-sa` must be renamed to `attribution-same-license` in https://commons.wikimedia.org/wiki/MediaWiki:Wikibasecirrus-license-mapping
[] `Q98923445` is added to the `attribution` category
[x] MediaSearch must change so that it does `haslicense:attribution` and `haslicense:attribution-same-license` search calls, instead of the old keywords
[x] MediaSearch must read the `haslicense` keywords from config instead of having them hardcoded
Note that this last criterium implies that there's total flexibility on the part of the community to come up with new license groups. This is acceptable.
There's 1 inherent problem there, though: they will not have i18n messages by default. It is possible to create messages on-wiki, though, so that would then also be in the community's control.
As long as we provide default messages for the existing 4 options, that's fine. Should the community ever decide to want to add another class of licenses, they then have all the tools needed to do so, without requiring an intervention from us.