Change Details

https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php%24&repos= lists some back-compatible code that was written for the PHP 5.3 era. This is no longer needed because [all MediaWiki versions that are nowadays supported require at least PHP version 7](https://en.wikipedia.org/wiki/MediaWiki_version_history). Go through that output, find two specific instances of such code, and clean them up in a patch! Example: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457812 Mentors: //(none)// **Search queries:** - [[ https://codesearch.wmflabs.org/search/?q=%5C%24(self%7Cthat)%20%3D%20%5C%24this%3B&i=nope&files=%5C.php%24&repos= | Implicit binding of `$this` in closures ]] - [[ https://codesearch.wmflabs.org/search/?q=(PHP%7C%20)(5%5C.%5B1-6X%5D%7C7%5C.%5B02%5D)%7CPHP%20%3F%5B57%5D%5B%5E.%5D&i=fosho&files=%5C.php%24&repos= | Mentions of old PHP versions in code ]] - [[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*callable%20*%5C*%5C%2F&i=nope&files=%5C.php%24&repos= | `callable` type hint ]] - [[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*(private%7Cprotected%7Cpublic)%20*%5C*%5C%2F%20*const&i=nope&files=%5C.php%24&repos= | Class constant visibility ]] - [[ https://codesearch.wmflabs.org/search/?q=%5C%5B%20*count%20*%5C(%5B%5E)%5D%2B%5C)%20*-%20*%5Cd%2B&i=nope&files=%5C.php%24&repos= | Negative indexing ]]

https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php%24&repos= lists some back-compatible code that was written for the PHP 5.3 era. This is no longer needed because [all MediaWiki versions that are nowadays supported require at least PHP version 7](https://en.wikipedia.org/wiki/MediaWiki_version_history). Go through that output, find two specific instances of such code, and clean them up in a patch! Example: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457812 Mentors: //(none)// **Search queries:** - [[ https://codesearch.wmflabs.org/search/?q=%5C%24(self%7Cthat)%20%3D%20%5C%24this%3B&i=nope&files=%5C.php%24&repos= | Implicit binding of "$this" in closures ]] - [[ https://codesearch.wmcloud.org/search/?q=(PHP(%20*%5B%3D%3C%3E%5D%2B%20*)%3F%7C%20)(5%5C.%5B1-6X%5D%7C7%5C.%5B0-3%5D)%7CPHP(%20*%5B%3D%3C%3E%5D%2B%20*)%3F%5B57%5D%5B%5E.%5D&i=fosho&files=%5C.php%24&repos= | Mentions of old PHP versions in code ]] - [[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*callable%20*%5C*%5C%2F&i=nope&files=%5C.php%24&repos= | "callable" type hint ]] - ~~[[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*(private%7Cprotected%7Cpublic)%20*%5C*%5C%2F%20*const&i=nope&files=%5C.php%24&repos= | Class constant visibility ]]~~ - [[ https://codesearch.wmflabs.org/search/?q=%5C%5B%20*count%20*%5C(%5B%5E)%5D%2B%5C)%20*-%20*%5Cd%2B&i=nope&files=%5C.php%24&repos= | Negative indexing ]]

https://codesearch.wmflabs.org/search/?q=5%5C.3&i=nope&files=%5C.php%24&repos= lists some back-compatible code that was written for the PHP 5.3 era. This is no longer needed because [all MediaWiki versions that are nowadays supported require at least PHP version 7](https://en.wikipedia.org/wiki/MediaWiki_version_history). Go through that output, find two specific instances of such code, and clean them up in a patch! Example: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457812 Mentors: //(none)// **Search queries:** - [[ https://codesearch.wmflabs.org/search/?q=%5C%24(self%7Cthat)%20%3D%20%5C%24this%3B&i=nope&files=%5C.php%24&repos= | Implicit binding of `"$this`" in closures ]] - [[ https://codesearch.wmflabswmcloud.org/search/?q=(PHP(%20*%5B%3D%3C%3E%5D%2B%20*)%3F%7C%20)(5%5C.%5B1-6X%5D%7C7%5C.%5B02-3%5D)%7CPHP%20(%20*%5B%3D%3C%3E%5D%2B%20*)%3F%5B57%5D%5B%5E.%5D&i=fosho&files=%5C.php%24&repos= | Mentions of old PHP versions in code ]] - [[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*callable%20*%5C*%5C%2F&i=nope&files=%5C.php%24&repos= | `"callable`" type hint ]] - ~~[[ https://codesearch.wmflabs.org/search/?q=%5C%2F%5C*%20*(private%7Cprotected%7Cpublic)%20*%5C*%5C%2F%20*const&i=nope&files=%5C.php%24&repos= | Class constant visibility ]]~~ - [[ https://codesearch.wmflabs.org/search/?q=%5C%5B%20*count%20*%5C(%5B%5E)%5D%2B%5C)%20*-%20*%5Cd%2B&i=nope&files=%5C.php%24&repos= | Negative indexing ]]