Change Details

In T209007 we started the deprecation process for className and isBorderBox properties on our View classes. The warning **Use of "className" is deprecated. Setting `className` on the View is deprecated. Please use options.** now shows for many workflows. This task completes the work by dropping those warnings and then restricting className and isBorderBox to be options only. This work puts us on course for making greater use of composition in our codebase. = Acceptance criteria [] className and isBorderBox are always passed by options. No deprecation notices can be shown in the console under any circumstances [] If a class extends View and defines className and isBorderBox these have no impact = Developer notes This is a 2 patch job - 1 to clean up the deprecation warnings, 1 to remove the root of the console.logs

In T209007 we started the deprecation process for className and isBorderBox properties on our View classes. The warning **Use of "className" is deprecated. Setting `className` on the View is deprecated. Please use options.** now shows for many workflows. This task completes the work by dropping those warnings and then restricting className and isBorderBox to be options only. This work puts us on course for making greater use of composition in our codebase. = Acceptance criteria [] `className` is always passed to the parent constructor rather than set as a property [] `isBorderBox` is always passed to the parent constructor rather than set as a property [] If a class extends `View` and defines `className` and `isBorderBox` these have no impact [] No deprecation notices can be shown in the console under any circumstances = Developer notes This is a 2 patch job - 1 to clean up the deprecation warnings, 1 to remove the root of the console.logs

In T209007 we started the deprecation process for className and isBorderBox properties on our View classes. The warning **Use of "className" is deprecated. Setting `className` on the View is deprecated. Please use options.** now shows for many workflows. This task completes the work by dropping those warnings and then restricting className and isBorderBox to be options only. This work puts us on course for making greater use of composition in our codebase. = Acceptance criteria [] className and isBorderBox are always passed by options. No deprecation notices can be shown in the console under any circumstances`className` is always passed to the parent constructor rather than set as a property [] `isBorderBox` is always passed to the parent constructor rather than set as a property [] If a class extends View and defines className and isBorderBox these have no impact`View` and defines `className` and `isBorderBox` these have no impact [] No deprecation notices can be shown in the console under any circumstances = Developer notes This is a 2 patch job - 1 to clean up the deprecation warnings, 1 to remove the root of the console.logs