Change Details

19:22 < Krinkle> ParserCache::save Memc set key: enwiki:pcache:idoptions:12108 - ok: true 19:22 < Krinkle> ParserCache::save Memc set key: enwiki:pcache:idhash:12108-0!canonical!tmh-videojs - ok: true 19:26 < Krinkle> Logstash: `channel:AdHocDebug OR channel:ParserCache OR message:parser OR message:parsercache` 19:26 < Krinkle> ParserOutput key valid, but rejected by RejectParserCacheValue hook handler. 19:28 < Krinkle> Prod extensions using this MW hook: Wikibase, ops/mediawiki-config, Kartographer, TimedMediaHandler Krinkle> So if you user pref and current object is differenet from site config, it always refuses to persist it Krinkle> so likely just induced by the beta pref more popular https://gerrit.wikimedia.org/g/mediawiki/extensions/TimedMediaHandler/+/a9a3b431d5c175778b076b7d6c230aa8280c121f/includes/TimedMediaHandlerHooks.php#525 So on RejectParserCacheValue of TimedMediaHandler only considers the site default, and not the activePlayerMode for the player. This was done for a site preference switch, but didn't account for user preference switches via beta player mode and the parsercachekey already being adapted according to this activePlayerMode. The mode has been available for a while already. Likely got more pervasive as parsercache values started expiring, more and more people get enrolled in the betafeature etc. Additionally the issue is only really noticeable if the parsercache performance actually matters aka. big pages only 19:59 < James_F> https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/530187 is the emergency disable patch if it's needed. 19:59 < James_F> It'll be messy, but it'd stop people adding the beta feature. 20:00 < James_F> (And as they touch their preferences, existing people would get emptied out.)

< Krinkle> ParserCache::save Memc set key: enwiki:pcache:idoptions:12108 - ok: true < Krinkle> ParserCache::save Memc set key: enwiki:pcache:idhash:12108-0!canonical!tmh-videojs true < Krinkle> Logstash: `channel:AdHocDebug OR channel:ParserCache OR message:parser OR e:parsercache` < Krinkle> ParserOutput key valid, but rejected by RejectParserCacheValue hook handler. < Krinkle> Prod extensions using this MW hook: Wikibase, ops/mediawiki-config, Kartographer, TimedMediaHandler Krinkle> So if you user pref and current object is different from site config, it always refuses to persist it Krinkle> so likely just induced by the beta pref more popular See also: https://gerrit.wikimedia.org/g/mediawiki/extensions/TimedMediaHandler/+/a9a3b431d5c175778b076b7d6c230aa8280c121f/includes/TimedMediaHandlerHooks.php#525 So on RejectParserCacheValue of TimedMediaHandler only considers the site default, and not the activePlayerMode for the player. This was done for a site preference switch, but didn't account for user preference switches via beta player mode and the parsercachekey already being adapted according to this activePlayerMode. The mode has been available for a while already. Likely got more pervasive as parsercache values started expiring, more and more people get enrolled in the betafeature etc. Additionally the issue is only really noticeable if the parsercache performance actually matters aka. big pages only < James_F> https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/530187 is the ncy disable patch if it's needed. < James_F> It'll be messy, but it'd stop people adding the beta feature. < James_F> (And as they touch their preferences, existing people would get emptied out.)

19:22 < Krinkle> ParserCache::save Memc set key: enwiki:pcache:idoptions:12108 - ok: true 19:22 < Krinkle> ParserCache::save Memc set key: enwiki:pcache:idhash:12108-0!canonical!tmh-videojs - ok: true 19:26 < Krinkle> Logstash: `channel:AdHocDebug OR channel:ParserCache OR message:parser OR message:parsercache` 19:26 < Krinkle> ParserOutput key valid, but rejected by RejectParserCacheValue hook handler. 19:28 < Krinkle> Prod extensions using this MW hook: Wikibase, ops/mediawiki-config, Kartographer, TimedMediaHandler Krinkle> So if you user pref and current object is differenet from site config, it always refuses to persist it Krinkle> so likely just induced by the beta pref more popular See also: https://gerrit.wikimedia.org/g/mediawiki/extensions/TimedMediaHandler/+/a9a3b431d5c175778b076b7d6c230aa8280c121f/includes/TimedMediaHandlerHooks.php#525 So on RejectParserCacheValue of TimedMediaHandler only considers the site default, and not the activePlayerMode for the player. This was done for a site preference switch, but didn't account for user preference switches via beta player mode and the parsercachekey already being adapted according to this activePlayerMode. The mode has been available for a while already. Likely got more pervasive as parsercache values started expiring, more and more people get enrolled in the betafeature etc. Additionally the issue is only really noticeable if the parsercache performance actually matters aka. big pages only 19:59 < James_F> https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/530187 is the emergency disable patch if it's needed. 19:59 < James_F> It'll be messy, but it'd stop people adding the beta feature. 20:00 < James_F> (And as they touch their preferences, existing people would get emptied out.)