- the doc with test case/CUJ scenarios - [[ https://docs.google.com/spreadsheets/d/1zocdydnt58PLthG9159E27MRBCIaACD_hPTfQAZh0Q0/edit?gid=1849756849#gid=1849756849 |testing Wikipedia Wikifunctions integration]]
- testing is done on `testwiki` with `?useparsoid=1`
====== Issues ======
**(3) The error message doesn't mention the wikifunction name**
**(2{F59250896}
**(4) No back button on the insertVE preview - after editing/updating wikifunction overlay?s on a page, a preview is shown only in wikitext. **
|[[ https://www.figma.com/design/sMOc0itmJIm6qthj8XKfMd/T363391-Design-prototype-for-WF-use-case-in-WP?node-id=1095-4805&p=f&t=yRPzVp89Mrfql4Be-0 | Figma design ]]| `testwiki wmf.25`- on `testwiki`, in User preferences - Editing enable the following settings (!!those settings are not default on testwiki!!)
|---|----- "Use the wikitext mode inside the visual editor, instead of a different wikitext editor" This is sometimes called the '2017 wikitext editor'.
|{F59250777}|{F59250816}-- "Use the new Parsoid wikitext parser: Always (opt-in)
- a user cannot return to the Search for wikifunctions overlay- in VE on any page insert any function, e.g. "Natural number as Roman numeral" (Z11022)
`{{#function:Z11022|123}} `
-- after the inserted wikifunctions is successfully displayed in VE, click on "Publish Changes"
- dismissing (clicking on `x`) will close the overlay and a user needs to click on the Insert menu and click on the Function menu item to start insertin a new wikifunction.- return to VE to correct the function you just inserted. to
`{{#function:Z11022|126}}`
-- click on "Publish Changes" - and in the "Save your changes" dialog, click on "Review your changes" - the wikitext review displays the changes correctly:
- no shortcuts for inserting wikifunctions (cmd+? for VE shortcuts){F59364485}
**(3) The error message doesn't mention the wikifunction name**-- switch to Visual preview - the Visual review is not loading and the Console displays the following error:
```
{F59250896} TypeError: Cannot read properties of null (reading 'length')
at ve.batchPush (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.core.utils&skin=vector-2022&version=1d3dw:3:400)
at eval (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:55:65)
at Array.forEach (<anonymous>)
at ve.ui.DiffElement.annotateNode (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:54:922)
at ve.ui.DiffElement.getChangedLeafNodeData (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:38:78)
at ve.ui.DiffElement.getChangedNodeData (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:37:488)
at ve.ui.DiffElement.getChangedNodeElements (https://test.wikipedia.org/w/load.php?lang=en&modules=ext.visualEditor.diffing&skin=vector-2022&version=1ib7h:37:223)
```
{F59364541}
-----------
(4) The error message for failed function is more visible on a page that, for example, the failed to be displayed template:
|{F59251502}|{F59251512}
==== DONE ===== * Issues that have been addressed =====
✅ **DONE - should be tested on `testwiki` with `?useparsoid=1` **(1** (1) Unable to publish (save) inserted function. View history and Special:Contributions show unsaved edits as completed.**
- https://test2.wikipedia.org/w/index.php?title=Mavetuna44&diff=584202&oldid=301014 shows `
{{#function:Z18435|2,025|Z16108|1}}` as added
- switch to Edit mode: "The function is unable to display a result. Learn more"
{F59045747}
- click in the error message - a suggestion to edit appears
{F59045771}
- click on Edit, the Console error is displayed:
```
Uncaught (in promise) Error: You have too many function calls executing right now.
```
✅ **As Designed** **(2) No back button on the insert wikifunction overlay? **
|[[ https://www.figma.com/design/sMOc0itmJIm6qthj8XKfMd/T363391-Design-prototype-for-WF-use-case-in-WP?node-id=1095-4805&p=f&t=yRPzVp89Mrfql4Be-0 | Figma design ]]| `testwiki wmf.25`
|---|---
|{F59250777}|{F59250816}
- a user cannot return to the Search for wikifunctions overlay
- dismissing (clicking on `x`) will close the overlay and a user needs to click on the Insert menu and click on the Function menu item to start insertin a new wikifunction.
- no shortcuts for inserting wikifunctions (cmd+? for VE shortcuts)