Change Details

@elukey reported that git repos in labspuppetmaster1001.wikimedia.org (/var/lib/git) have different owners, for example: ``` aborrero@labpuppetmaster1001:/var/lib/git/operations/puppet$ ls -la total 120 drwxr-xr-x 12 gitpuppet gitpuppet 4096 Jan 5 08:54 . drwxr-xr-x 4 root root 4096 Jul 27 15:12 .. drwxr-xr-x 6 gitpuppet gitpuppet 4096 Jul 27 15:12 conftool-data -rw-r--r-- 1 gitpuppet gitpuppet 323 Jul 27 15:12 .ctags drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jul 27 15:12 doc drwxr-xr-x 4 gitpuppet gitpuppet 4096 Jul 27 15:12 environments drwxr-xr-x 3 gitpuppet gitpuppet 4096 Jul 27 15:12 files -rw-r--r-- 1 root root 473 Nov 30 15:26 Gemfile drwxr-xr-x 9 gitpuppet gitpuppet 4096 Jan 5 09:40 .git -rw-r--r-- 1 root root 509 Oct 3 13:20 .gitignore -rw-r--r-- 1 gitpuppet gitpuppet 717 Jul 27 15:12 .gitmodules -rw-r--r-- 1 gitpuppet gitpuppet 101 Jul 27 15:12 .gitreview drwxr-xr-x 11 gitpuppet gitpuppet 4096 Jan 5 08:54 hieradata -rw-r--r-- 1 gitpuppet gitpuppet 9694 Jul 27 15:12 .mailmap drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 manifests drwxr-xr-x 242 gitpuppet gitpuppet 12288 Jan 5 08:54 modules -rw-r--r-- 1 gitpuppet gitpuppet 239 Jul 27 15:12 .puppet-lint.rc -rw-r--r-- 1 root root 3611 Oct 20 14:33 Rakefile drwxr-xr-x 2 root root 4096 Nov 30 15:18 rake_modules -rw-r--r-- 1 gitpuppet gitpuppet 783 Jul 27 15:12 README -rw-r--r-- 1 root root 3981 Dec 12 14:46 .rubocop_todo.yml -rw-r--r-- 1 gitpuppet gitpuppet 1129 Jul 27 15:12 .rubocop.yml -rw-r--r-- 1 root root 7 Aug 3 12:51 .ruby-version -rw-r--r-- 1 root root 1541 Dec 14 17:43 tox.ini -rw-r--r-- 1 root root 465 Jan 5 08:54 typos drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 utils ``` And also: ``` aborrero@labpuppetmaster1001:/var/lib/git/operations/puppet$ ls -la modules/role/manifests/puppetmaster/ total 24 drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 . drwxr-xr-x 80 gitpuppet gitpuppet 4096 Jan 5 08:54 .. -rw-r--r-- 1 gitpuppet gitpuppet 346 Jul 27 15:12 backend.pp -rw-r--r-- 1 gitpuppet gitpuppet 515 Jul 27 15:12 frontend.pp -rw-r--r-- 1 root root 2482 Dec 7 21:29 puppetdb.pp -rw-r--r-- 1 root root 3004 Jan 5 08:54 standalone.pp ``` This is perhaps related to direct modifications being to files in this repo, and later running `git checkout`. But we should have consistency in the owners.

@elukey reported that git repos in labpuppetmaster1001.wikimedia.org (/var/lib/git) have different owners, for example: ``` aborrero@labpuppetmaster1001:/var/lib/git/operations/puppet$ ls -la total 120 drwxr-xr-x 12 gitpuppet gitpuppet 4096 Jan 5 08:54 . drwxr-xr-x 4 root root 4096 Jul 27 15:12 .. drwxr-xr-x 6 gitpuppet gitpuppet 4096 Jul 27 15:12 conftool-data -rw-r--r-- 1 gitpuppet gitpuppet 323 Jul 27 15:12 .ctags drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jul 27 15:12 doc drwxr-xr-x 4 gitpuppet gitpuppet 4096 Jul 27 15:12 environments drwxr-xr-x 3 gitpuppet gitpuppet 4096 Jul 27 15:12 files -rw-r--r-- 1 root root 473 Nov 30 15:26 Gemfile drwxr-xr-x 9 gitpuppet gitpuppet 4096 Jan 5 09:40 .git -rw-r--r-- 1 root root 509 Oct 3 13:20 .gitignore -rw-r--r-- 1 gitpuppet gitpuppet 717 Jul 27 15:12 .gitmodules -rw-r--r-- 1 gitpuppet gitpuppet 101 Jul 27 15:12 .gitreview drwxr-xr-x 11 gitpuppet gitpuppet 4096 Jan 5 08:54 hieradata -rw-r--r-- 1 gitpuppet gitpuppet 9694 Jul 27 15:12 .mailmap drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 manifests drwxr-xr-x 242 gitpuppet gitpuppet 12288 Jan 5 08:54 modules -rw-r--r-- 1 gitpuppet gitpuppet 239 Jul 27 15:12 .puppet-lint.rc -rw-r--r-- 1 root root 3611 Oct 20 14:33 Rakefile drwxr-xr-x 2 root root 4096 Nov 30 15:18 rake_modules -rw-r--r-- 1 gitpuppet gitpuppet 783 Jul 27 15:12 README -rw-r--r-- 1 root root 3981 Dec 12 14:46 .rubocop_todo.yml -rw-r--r-- 1 gitpuppet gitpuppet 1129 Jul 27 15:12 .rubocop.yml -rw-r--r-- 1 root root 7 Aug 3 12:51 .ruby-version -rw-r--r-- 1 root root 1541 Dec 14 17:43 tox.ini -rw-r--r-- 1 root root 465 Jan 5 08:54 typos drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 utils ``` And also: ``` aborrero@labpuppetmaster1001:/var/lib/git/operations/puppet$ ls -la modules/role/manifests/puppetmaster/ total 24 drwxr-xr-x 2 gitpuppet gitpuppet 4096 Jan 5 08:54 . drwxr-xr-x 80 gitpuppet gitpuppet 4096 Jan 5 08:54 .. -rw-r--r-- 1 gitpuppet gitpuppet 346 Jul 27 15:12 backend.pp -rw-r--r-- 1 gitpuppet gitpuppet 515 Jul 27 15:12 frontend.pp -rw-r--r-- 1 root root 2482 Dec 7 21:29 puppetdb.pp -rw-r--r-- 1 root root 3004 Jan 5 08:54 standalone.pp ``` This is perhaps related to direct modifications being to files in this repo, and later running `git checkout`. But we should have consistency in the owners.