Change Details

Input (semicolon and minus sign, invalid javascript): ``` ; - ``` When parsing this, instead of throwing a "Parser error", the parser loses track somehow and emits: ``` Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968 ``` https://github.com/wikimedia/mediawiki/blob/16e3524bcab07f4f391cc32347d8732d734b1058/includes/libs/jsminplus.php#L1968 ``` if (in_array($op, $this->assignOps) && $input[strlen($op)] == '=') ``` Variable dump from this location: ``` $op string '-' (length=1) $input string '-' (length=1) $match array (size=2) 0 => string '-' (length=1) 1 => string '-' (length=1) ```

Input (semicolon and minus sign, invalid javascript): ``` ; - ``` When parsing this, instead of throwing a "Parser error", the parser loses track somehow and emits: ``` Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968 ``` https://github.com/wikimedia/mediawiki/blob/16e3524bcab07f4f391cc32347d8732d734b1058/includes/libs/jsminplus.php#L1968 ``` if (in_array($op, $this->assignOps) && $input[strlen($op)] == '=') ``` Variable dump from this location: ``` $op string '-' (length=1) $input string '-' (length=1) $match array (size=2) 0 => string '-' (length=1) 1 => string '-' (length=1) ``` See also: * {T75556}

Input (semicolon and minus sign, invalid javascript): ``` ; - ``` When parsing this, instead of throwing a "Parser error", the parser loses track somehow and emits: ``` Notice: Uninitialized string offset: 1 in includes/libs/jsminplus.php on line 1968 ``` https://github.com/wikimedia/mediawiki/blob/16e3524bcab07f4f391cc32347d8732d734b1058/includes/libs/jsminplus.php#L1968 ``` if (in_array($op, $this->assignOps) && $input[strlen($op)] == '=') ``` Variable dump from this location: ``` $op string '-' (length=1) $input string '-' (length=1) $match array (size=2) 0 => string '-' (length=1) 1 => string '-' (length=1) ``` See also: * {T75556}