Change Details

During CR for T231170/T231172, I noticed in `global_block_whitelist` that two columns are `varchar` not `varbinary` ```lang=sql CREATE TABLE /*_*/global_block_whitelist ( gbw_id int(11) NOT NULL PRIMARY KEY, -- Key to gb_id in globalblocks database. gbw_address varbinary(255) NOT NULL, gbw_by int(11) NOT NULL, -- Key to user_id gbw_by_text varchar(255) NOT NULL, gbw_reason varchar(255) NOT NULL, gbw_expiry binary(14) NOT NULL ) /*$wgDBTableOptions*/; ``` We should fix and normalise this, and then the DBAs can fix this with less work in T231172

During CR for T231170/T231172, I noticed in `global_block_whitelist` that two columns are `varchar` not `varbinary` ```lang=sql CREATE TABLE /*_*/global_block_whitelist ( gbw_id int(11) NOT NULL PRIMARY KEY, -- Key to gb_id in globalblocks database. gbw_address varbinary(255) NOT NULL, gbw_by int(11) NOT NULL, -- Key to user_id gbw_by_text varchar(255) NOT NULL, gbw_reason varchar(255) NOT NULL, gbw_expiry binary(14) NOT NULL ) /*$wgDBTableOptions*/; ``` We should fix and normalise this, and then the DBAs can fix this with less work in T231172 We can change `gbw_reason` in T231170 to make it easier, and then just do `gbw_by_text` on a separate patch

During CR for T231170/T231172, I noticed in `global_block_whitelist` that two columns are `varchar` not `varbinary` ```lang=sql CREATE TABLE /*_*/global_block_whitelist ( gbw_id int(11) NOT NULL PRIMARY KEY, -- Key to gb_id in globalblocks database. gbw_address varbinary(255) NOT NULL, gbw_by int(11) NOT NULL, -- Key to user_id gbw_by_text varchar(255) NOT NULL, gbw_reason varchar(255) NOT NULL, gbw_expiry binary(14) NOT NULL ) /*$wgDBTableOptions*/; ``` We should fix and normalise this, and then the DBAs can fix this with less work in T231172 We can change `gbw_reason` in T231170 to make it easier, and then just do `gbw_by_text` on a separate patch