Change Details

As was reported in [[ https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#New_Issue%3F | Wikipedia talk:Page Curation#New issue? ]], the curation toolbar is not present on pages that are supposed to have it. When testing for possible scenarios/causes for the inconsistent behavior of the curation toolbar, I found two cases when the toolbar is not present: (1) If a user is logged for sometime and has Special:NewPagesFeed open, then clicking on 'Review' will display a page without toolbar. To work around it - a user may re-login or click on 'Curate this article' link on the left side nav panel. (2) (seems to be specific to User namespace only) - create a page in User namespace and make sure that it shows in NPP feed - click on 'Review', the page will display the curation toolbar. - go to either Contributions or to Recent changes - locate the same page - click on a page, the page won't display the curation toolbar.

As was reported in [[ https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#New_Issue%3F | Wikipedia talk:Page Curation#New issue? ]], the curation toolbar is not present on pages that are supposed to have it. When testing for possible scenarios/causes for the inconsistent behavior of the curation toolbar, I found two cases when the toolbar is not present: (1) If a user is logged for sometime and has Special:NewPagesFeed open, then clicking on 'Review' will display a page without toolbar. To work around it - a user may re-login or click on 'Curate this article' link on the left side nav panel. (2) (seems to be specific to User namespace only) - create a page in User namespace and make sure that it shows in NPP feed - click on 'Review', the page will display the curation toolbar. - go to either Contributions or to Recent changes - locate the same page - click on a page, the page won't display the curation toolbar. --- Per discussion with Aaron, Roan and Stephane, we will rely on a combination of query parameters (always show if clicking "Review" from the main list UI) and WAN cache. It may make sense to keep the localStorage check since the code is already there, so on any given article we would: 1. Check if query parameter for `showcurationtoolbar` is set, show the toolbar. If the parameter is not set, go to next step. 1. Check localStorage and compare the last-use param to current timestamp. If localStorage doesn't have this property set, then go to next step. 1. Check the WAN cache for last-use for a given user ID. If that's not set, then don't show the toolbar. On the NewPagesFeed page, when listControlNav finishes initializing we will want to update the cache with the user's last use info and set a 24 hour TTL.

As was reported in [[ https://en.wikipedia.org/wiki/Wikipedia_talk:Page_Curation#New_Issue%3F | Wikipedia talk:Page Curation#New issue? ]], the curation toolbar is not present on pages that are supposed to have it. When testing for possible scenarios/causes for the inconsistent behavior of the curation toolbar, I found two cases when the toolbar is not present: (1) If a user is logged for sometime and has Special:NewPagesFeed open, then clicking on 'Review' will display a page without toolbar. To work around it - a user may re-login or click on 'Curate this article' link on the left side nav panel. (2) (seems to be specific to User namespace only) - create a page in User namespace and make sure that it shows in NPP feed - click on 'Review', the page will display the curation toolbar. - go to either Contributions or to Recent changes - locate the same page - click on a page, the page won't display the curation toolbar. --- Per discussion with Aaron, Roan and Stephane, we will rely on a combination of query parameters (always show if clicking "Review" from the main list UI) and WAN cache. It may make sense to keep the localStorage check since the code is already there, so on any given article we would: 1. Check if query parameter for `showcurationtoolbar` is set, show the toolbar. If the parameter is not set, go to next step. 1. Check localStorage and compare the last-use param to current timestamp. If localStorage doesn't have this property set, then go to next step. 1. Check the WAN cache for last-use for a given user ID. If that's not set, then don't show the toolbar. On the NewPagesFeed page, when listControlNav finishes initializing we will want to update the cache with the user's last use info and set a 24 hour TTL.