Change Details

{icon chevron-left} {T395347} | {T429706} {icon chevron-right} #### What This ticket is to raise the Grade A requirement for the Modern JS layer from ES2018 to the next milestone ES2019 (ECMAScript 10). #### Why This will allow MediaWiki JavaScript code to use the following syntax, internal functions, and other features, improving the developer experience: * [[ https://node.green/#ES2019 | ES2019 ]] ** string trimming: `String.trimStart()/String.trimEnd()` ** `Object.fromEntries` ** Optional catch Binding ** `Array.flat()` and `flatMap()` #### Blockers * [x] Peast validator: already [[ https://phabricator.wikimedia.org/T277675#9528940 | supports any ES version upto ES2024 ]] * [x] JavaScriptMinifier support for ES2019 syntax: {T386530} * [x] figure out what browsers we would drop out of Grade A because of this * [] Browser market share for older browser versions is low enough. We should get signoff from a WMF dev for this. Maybe @Krinkle? #### Todo Once unblocked: (see old ticket T381537 for patch examples) 1. [] ResourceLoader: * [] update startup.js to raise feature tests requirement to ES2019 * [] update Peast calls in Module::validateScriptFile(), maintenance/benchmarks/benchmarkJsValidate.php, and [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CodeMirror/+/refs/heads/master/includes/JavaScriptValidator.php | CodeMirror ]] to allow ES2019, and bump USERJSPARSE_CACHE_VERSION 2. [] [[ https://github.com/wikimedia/eslint-config-wikimedia | eslint-config-wikimedia ]]: * [] update "client" preset to allow ES2019 * [] publish release to npm * [] notify [[ https://www.mediawiki.org/wiki/LibUp | LibUp ]] to upgrade this across repos automatically. 3. [] Documentation: * [] Draft an entry for Tech News * [] Update https://www.mediawiki.org/wiki/Compatibility#General_information

{icon chevron-left} {T395347} | {T429706} {icon chevron-right} #### What This ticket is to raise the Grade A requirement for the Modern JS layer from ES2018 to the next milestone ES2019 (ECMAScript 10). #### Why This will allow MediaWiki JavaScript code to use the following syntax, internal functions, and other features, improving the developer experience: * [[ https://node.green/#ES2019 | ES2019 ]] ** string trimming: `String.trimStart()/String.trimEnd()` ** `Object.fromEntries` ** Optional catch Binding ** `Array.flat()` and `flatMap()` #### Blockers * [x] Peast validator: already [[ https://phabricator.wikimedia.org/T277675#9528940 | supports any ES version upto ES2024 ]] * [x] JavaScriptMinifier support for ES2019 syntax: {T386530} * [x] figure out what browsers we would drop out of Grade A because of this * [x] Browser market share for older browser versions is low enough. Signoff from MediaWiki Platform Team. Maybe @Krinkle or @JTweed-WMF #### Todo Once unblocked: (see old ticket T381537 for patch examples) 1. [] ResourceLoader: * [] update startup.js to raise feature tests requirement to ES2019 * [] update Peast calls in Module::validateScriptFile(), maintenance/benchmarks/benchmarkJsValidate.php, and [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CodeMirror/+/refs/heads/master/includes/JavaScriptValidator.php | CodeMirror ]] to allow ES2019, and bump USERJSPARSE_CACHE_VERSION 2. [] [[ https://github.com/wikimedia/eslint-config-wikimedia | eslint-config-wikimedia ]]: * [] update "client" preset to allow ES2019 * [] publish release to npm * [] notify [[ https://www.mediawiki.org/wiki/LibUp | LibUp ]] to upgrade this across repos automatically. 3. [] Documentation: * [] Draft an entry for Tech News * [] Update https://www.mediawiki.org/wiki/Compatibility#General_information

{icon chevron-left} {T395347} | {T429706} {icon chevron-right} #### What This ticket is to raise the Grade A requirement for the Modern JS layer from ES2018 to the next milestone ES2019 (ECMAScript 10). #### Why This will allow MediaWiki JavaScript code to use the following syntax, internal functions, and other features, improving the developer experience: * [[ https://node.green/#ES2019 | ES2019 ]] ** string trimming: `String.trimStart()/String.trimEnd()` ** `Object.fromEntries` ** Optional catch Binding ** `Array.flat()` and `flatMap()` #### Blockers * [x] Peast validator: already [[ https://phabricator.wikimedia.org/T277675#9528940 | supports any ES version upto ES2024 ]] * [x] JavaScriptMinifier support for ES2019 syntax: {T386530} * [x] figure out what browsers we would drop out of Grade A because of this * [x] Browser market share for older browser versions is low enough. We should get sSignoff from a WMF dev for thisMediaWiki Platform Team. Maybe @Krinkle? or @JTweed-WMF #### Todo Once unblocked: (see old ticket T381537 for patch examples) 1. [] ResourceLoader: * [] update startup.js to raise feature tests requirement to ES2019 * [] update Peast calls in Module::validateScriptFile(), maintenance/benchmarks/benchmarkJsValidate.php, and [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CodeMirror/+/refs/heads/master/includes/JavaScriptValidator.php | CodeMirror ]] to allow ES2019, and bump USERJSPARSE_CACHE_VERSION 2. [] [[ https://github.com/wikimedia/eslint-config-wikimedia | eslint-config-wikimedia ]]: * [] update "client" preset to allow ES2019 * [] publish release to npm * [] notify [[ https://www.mediawiki.org/wiki/LibUp | LibUp ]] to upgrade this across repos automatically. 3. [] Documentation: * [] Draft an entry for Tech News * [] Update https://www.mediawiki.org/wiki/Compatibility#General_information