Hello, I have a few concerns with the way mediawiki/extensions/PageAssessments.git has been created and is contributed to. Maybe I am too idealist but here are a few things that are worth fixing up:
It has created by importing the whole history of the BoilerPlate extension then lot of bits got removed. The history is misleading as a result. I would recommend to recreate it entirely:
* craft an initial commit introducing the .gitreview file (with the proper repo) and force push it to get rid of the history
* create another patch that introduce the basic structure and send it for review in Gerrit so at least we know the bases are proper.
Then get the development going on.
A second concern is that changes are being pushed directly to Gerrit bypassing review entirely. If the extension is to be deployed to production, the change have to be peer reviewed.
Finally we would need some basic CI on the repo. Most probably as part of the first commit proposing code. The entry points and basic commands are included in BoilerPlate but would still need to be tweaked and validated by CI.
The CI configuration itself is straightforward. A recent example is f634123123edb963ae31f0528d6bccf7fee147d4 for the extension EventBus. That would work for PageAssesment.
Feel free to poke #wikimedia-releng or myself on IRC (`hashar` , Europe).