Change Details

== Issue description == Trying to upload a new version of whatever file on (whatever?) MediaWiki you reach a rude `Special:Upload` page with a multi-line field called "File changes:". The issue is that, after pressing "Save", your message is collapsed as a single-line, worsening the readability of the user's message and potentially changing its meaning. > {F33995590} > The field "File changes:" is highlighted in the above screenshot (with some green peppers). > You can see it online here: https://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Asd.gif&wpForReUpload=1 > That URL can be reached from the "Upload a new version of this file" link from whatever page in the `File:` namespace. For example if an user inputs this multi-line text: ``` added a pack of cigarettes to promote freedom added a sticker ``` Actually the user saves this single-line edit summary: ``` added a pack of cigarettes to promote freedom added a sticker ``` This seems an old #ux-debt affecting whatever MediaWiki file page. == Proposed solution == The proposed solution is to update the `Special:Upload` page to do not generate anymore this HTML tag: ``` <textarea id="wpUploadDescription" cols="80" rows="8" name="wpUploadDescription"></textarea> ``` But generate something like this instead: ``` <input type="text" id="wpUploadDescription" name="wpUploadDescription"></textarea> ``` In this way the user will not be tempted to enter multiple lines, while we do not supports newlines in an edit summary. AFAIK this may be achieved just updating this highlighted block of source code: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/forms/UploadForm.php;90996aa040c93e3d0df6e2b640c3dc799df0556d$333-343 Well it seems a cute #good_first_task. Happy hacking!

== Issue description == Trying to upload a new version of whatever file on (whatever?) MediaWiki you reach a rude `Special:Upload` page with a multi-line field called "File changes:". The issue is that, after pressing "Save", your message is collapsed as a single-line, worsening the readability of the user's message and potentially changing its meaning. > {F33995590} > The field "File changes:" is highlighted in the above screenshot (with some green peppers). > You can see it online here: https://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Asd.gif&wpForReUpload=1 > That URL can be reached from the "Upload a new version of this file" link from whatever page in the `File:` namespace. For example if an user inputs this multi-line text: ``` added a pack of cigarettes to promote freedom added a sticker ``` Actually the user saves this single-line edit summary: ``` added a pack of cigarettes to promote freedom added a sticker ``` This seems an old #ux-debt affecting whatever MediaWiki file page. == Proposed solution == The proposed solution is to update the `Special:Upload` page to do not generate anymore this HTML tag: ``` <textarea id="wpUploadDescription" cols="80" rows="8" name="wpUploadDescription"></textarea> ``` But generate something like this instead: ``` <input type="text" id="wpUploadDescription" name="wpUploadDescription"></textarea> ``` In this way the user will not be tempted to enter multiple lines, while we do not support newlines in an edit summary. AFAIK this may be achieved just updating this highlighted block of source code: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/forms/UploadForm.php;90996aa040c93e3d0df6e2b640c3dc799df0556d$333-343 Well. It seems a cute #good_first_task. Happy hacking!

== Issue description == Trying to upload a new version of whatever file on (whatever?) MediaWiki you reach a rude `Special:Upload` page with a multi-line field called "File changes:". The issue is that, after pressing "Save", your message is collapsed as a single-line, worsening the readability of the user's message and potentially changing its meaning. > {F33995590} > The field "File changes:" is highlighted in the above screenshot (with some green peppers). > You can see it online here: https://commons.wikimedia.org/w/index.php?title=Special:Upload&wpDestFile=Asd.gif&wpForReUpload=1 > That URL can be reached from the "Upload a new version of this file" link from whatever page in the `File:` namespace. For example if an user inputs this multi-line text: ``` added a pack of cigarettes to promote freedom added a sticker ``` Actually the user saves this single-line edit summary: ``` added a pack of cigarettes to promote freedom added a sticker ``` This seems an old #ux-debt affecting whatever MediaWiki file page. == Proposed solution == The proposed solution is to update the `Special:Upload` page to do not generate anymore this HTML tag: ``` <textarea id="wpUploadDescription" cols="80" rows="8" name="wpUploadDescription"></textarea> ``` But generate something like this instead: ``` <input type="text" id="wpUploadDescription" name="wpUploadDescription"></textarea> ``` In this way the user will not be tempted to enter multiple lines, while we do not supports newlines in an edit summary. AFAIK this may be achieved just updating this highlighted block of source code: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/forms/UploadForm.php;90996aa040c93e3d0df6e2b640c3dc799df0556d$333-343 Well it. It seems a cute #good_first_task. Happy hacking!