Change Details

The message "Send public thanks for this edit?" is confusing. Someone misinterpreted it as giving you a choice of "Send public thanks" vs. implicit "Send private thanks". Actually the choice is "Send public thanks" vs. "Don't send thanks". {F5801023} I think the simplest solution is to change it to Thank/Cancel links instead of Yes/No. I.E. Send public thanks for this edit? [Thank] [Cancel] Or Send/Cancel This is a trivial change, if we do it like that. We can consider other options as well. For context, see {T49658} (which introduced the original confirmation with a different message), {T90486} (about 'publicly'), and most recently {T158918}.

The message "Send public thanks for this edit?" is confusing. People have been known to misinterpret it it as giving the user a choice of "Send public thanks" vs. "Send private thanks". Actually the choice is "Send public thanks" vs. "Don't send thanks". Although the idea of informing users that thanks are public—which some users find mandatory (T90486)—complicates this somewhat, it is easy enough to clarify the function: Existing language {F5801023} ===Changes to be made: - Change language as follows (observing changes in boldface, as shown): - **Send thank you? [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | send ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | cancel ]] ** (All thanks are public.) - please put an extra space or to between "send" and "cancel" - Currently, the whole phrase appears inside parentheses, and the open parenthesis gets broken off from the phrase and remains on the line above. (see screenshot). If possible, it would be nice to fix this as follows: - Remove the parentheses altogether after the user clicks "Thank". If that is not possible. - Make sure the open parenthesis stays on the same line as the rest of the text. ( The revised phrase should not cause the line to be longer than the line above it, so should not cause any problems with breaking. If it does, there are a lot of ways to shorten this text. E.g., - **Send thank you? [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | yes ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | no ]] ** (All thanks are public.)) OR **Send thanks? [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | yes ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | no ]] ** (All thanks are public.))

The message "Send public thanks for this edit?" is confusing. SomeonePeople have been known to misinterpreted it it as giving youthe user a choice of "Send public thanks" vs. implicit "Send private thanks". Actually the choice is "Send public thanks" vs. "Don't send thanks". Although the idea of informing users that thanks are public—which some users find mandatory (T90486)—complicates this somewhat, it is easy enough to clarify the function: Existing language {F5801023} I think the simplest solution is to c===Change its to Thank/Cancel links instead of Yes/No. I.E.be made: Send public thanks for this edit - Change language as follows (observing changes in boldface, as shown): - **Send thank you? [Thank] [Cancel] Or Send/Cancel This is a trivial change[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | send ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | cancel ]] ** (All thanks are public.) - please put an extra space or to between "send" and "cancel" - Currently, the whole phrase appears inside parentheses, if we do it like thatand the open parenthesis gets broken off from the phrase and remains on the line above. We can consider other options as well. For context,(see screenshot). If possible, it would be nice to fix this as follows: - Remove the parentheses altogether after the user clicks "Thank". If that is not possible. - Make sure the open parenthesis stays on the same line as the rest of the text. ( The revised phrase should not cause the line to be longer than the line above it, so should not cause any problems with breaking. If it does, there are a lot of ways to shorten this text. see {T49658} (which introduced the original confirmation with a different message),E.g., - **Send thank you? {T90486} (about 'publicly'),[[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | yes ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | no ]] ** (All thanks are public.)) OR **Send thanks? and most recently {T158918}.[[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | yes ]] [[ https://phabricator.wikimedia.org/maniphest/task/edit/159302/ | no ]] ** (All thanks are public.))