Change Details

Compare * https://meta.wikimedia.org/wiki/Special:AbuseLog/1128278 - details shown, [associated edit not revision deleted](https://meta.wikimedia.org/w/index.php?title=User_talk:QueerEcofeminist&diff=prev&oldid=20679547) * https://meta.wikimedia.org/wiki/Special:AbuseLog/1128311 - details line not shown, though all of the details are, [associated edit revision deleted](https://meta.wikimedia.org/w/index.php?title=User_talk:Tegel&diff=prev&oldid=20679658) Attempted debugging: Looking at the dom shows that there is an empty <p> element where the info should be, and the only reason I could find for that to be the case would be https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/d7a1d9ac4c220515aa3bd7b554bd73e4dc11d959/includes/special/SpecialAbuseLog.php#1091 * revision is rev-deled, so SpecialAbuseLog::isHidden returns 'implicit' * early return without the overall hit summary because 'implicit' is truthy * rest of the form is still shown because as a sysop I can see the underlying revision * fix is probably allowing $hidden to be 'implicit' if $isListItem is false

Specifically, the message `abusefilter-log-detailedentry-meta` is missing Attempted debugging: Looking at the dom shows that there is an empty <p> element where the info should be, and the only reason I could find for that to be the case would be https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/d7a1d9ac4c220515aa3bd7b554bd73e4dc11d959/includes/special/SpecialAbuseLog.php#1091 * revision is rev-deled, so SpecialAbuseLog::isHidden returns 'implicit' * early return without the overall hit summary because 'implicit' is truthy * rest of the form is still shown because as a sysop I can see the underlying revision * fix is probably allowing $hidden to be 'implicit' if $isListItem is false

Compare * https://meta.wikimedia.org/wiki/Special:AbuseLog/1128278 - details shown, [associated edit not revision deleted](https://meta.wikimedia.org/w/index.php?title=User_talk:QueerEcofeminist&diff=prev&oldid=20679547) * https://meta.wikimedia.org/wiki/Special:AbuseLog/1128311 - details line not shown, though all of the details areSpecifically, [associated edit revision deleted](https://meta.wikimedia.org/w/index.php?title=User_talk:Tegel&diff=prev&oldid=20679658)the message `abusefilter-log-detailedentry-meta` is missing Attempted debugging: Looking at the dom shows that there is an empty <p> element where the info should be, and the only reason I could find for that to be the case would be https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/d7a1d9ac4c220515aa3bd7b554bd73e4dc11d959/includes/special/SpecialAbuseLog.php#1091 * revision is rev-deled, so SpecialAbuseLog::isHidden returns 'implicit' * early return without the overall hit summary because 'implicit' is truthy * rest of the form is still shown because as a sysop I can see the underlying revision * fix is probably allowing $hidden to be 'implicit' if $isListItem is false