Change Details

**Author:** `ayg` **Description:** $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math,../extensions}/{*,*/*,*/*/*,*/*/*/*}/*.php *.php 2> /dev/null | wc -l 481 That's a lot of == '' and != ''. These should all be examined and fixed to either check strictly (if that's desired) or, I guess, drop the equality check, since that's more explicit. Of course, this doesn't count all the cases where you say !$var and assume strong type checking, but there's not much hope for automatically detecting those. Core looks a little better: $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math}/{*,*/*,*/*/*}/*.php *.php 2> /dev/null | wc -l 27 I'll get on some of these, maybe, if I have the time. -------------------------- **Version**: 1.12.x **Severity**: enhancement

**Author:** `ayg` **Description:** ``` $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math,../extensions}/{*,*/*,*/*/*,*/*/*/*}/*.php *.php 2> /dev/null | wc -l 481 ``` That's a lot of == '' and != ''. These should all be examined and fixed to either check strictly (if that's desired) or, I guess, drop the equality check, since that's more explicit. Of course, this doesn't count all the cases where you say !$var and assume strong type checking, but there's not much hope for automatically detecting those. Core looks a little better: ``` $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math}/{*,*/*,*/*/*}/*.php *.php 2> /dev/null | wc -l 27 ``` I'll get on some of these, maybe, if I have the time. -------------------------- **Version**: 1.12.x **Severity**: enhancement

**Author:** `ayg` **Description:** ``` $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math,../extensions}/{*,*/*,*/*/*,*/*/*/*}/*.php *.php 2> /dev/null | wc -l 481 ``` That's a lot of == '' and != ''. These should all be examined and fixed to either check strictly (if that's desired) or, I guess, drop the equality check, since that's more explicit. Of course, this doesn't count all the cases where you say !$var and assume strong type checking, but there's not much hope for automatically detecting those. Core looks a little better: ``` $ grep "\([^\!=]==\|\!=\)\s*''" {includes,skins,languages,maintenance,math}/{*,*/*,*/*/*}/*.php *.php 2> /dev/null | wc -l 27 ``` I'll get on some of these, maybe, if I have the time. -------------------------- **Version**: 1.12.x **Severity**: enhancement