Change Details

https://gerrit.wikimedia.org/r/#/c/406633/ introduced a browser test that is not compatible with the Minerva skin. All patches in Minerva are currently rejected by Jenkins. It seems strange as the screenshot for the failure shows that the element is present in the page so it's unclear why this fails from the information provided. Unrelated to Jenkins failure but worth considering: It's also not clear why this browser test is in core given that the usermessage div is created by skins not by core. Some skins do not make use of it. We may want to consider abstracting this and making this a function of skin e.g. Skin::userMessage

https://gerrit.wikimedia.org/r/#/c/406633/ introduced a browser test that is not compatible with the Minerva skin. All patches in Minerva are currently rejected by Jenkins (and we can't override verified). e.g. https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/13853/console on patch https://gerrit.wikimedia.org/r/#/c/406618/ It seems strange as the screenshot for the failure shows that the element is present in the page so it's unclear why this fails from the information provided. Unrelated to Jenkins failure but worth considering: It's also not clear why this browser test is in core given that the usermessage div is created by skins not by core. Some skins do not make use of it. We may want to consider abstracting this and making this a function of skin e.g. Skin::userMessage

https://gerrit.wikimedia.org/r/#/c/406633/ introduced a browser test that is not compatible with the Minerva skin. All patches in Minerva are currently rejected by Jenkins. (and we can't override verified). e.g. https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/13853/console on patch https://gerrit.wikimedia.org/r/#/c/406618/ It seems strange as the screenshot for the failure shows that the element is present in the page so it's unclear why this fails from the information provided. Unrelated to Jenkins failure but worth considering: It's also not clear why this browser test is in core given that the usermessage div is created by skins not by core. Some skins do not make use of it. We may want to consider abstracting this and making this a function of skin e.g. Skin::userMessage