Change Details

The sonar code health analysis has surfaced a [strange piece of code](https://sonarcloud.io/project/issues?id=mediawiki-extensions-Wikibase&open=AWt1uNEeBeEiCS_y_c0G&severities=MAJOR&statuses=OPEN&types=BUG): ```lang=php, name=MatchingTermsLookupSearchInteractor.php if ( count( $matchedTermIndexEntries ) > $limit ) { array_slice( $matchedTermIndexEntries, 0, $limit, true ); } ``` PHP's [array_slice](https://www.php.net/manual/en/function.array-slice.php) does not mutate its arguments but instead returns a value. That returned value is not used here, so something is wrong. * [ ] Figure out what is going on. Do we actually have a bug here that can be somehow seen in production? * [ ] Try to understand why there are no tests failing (are there none for that feature?) * [ ] Fix it (either remove it if it is not used or fix it and write a test for it if it is an actual bug in prod)

The sonar code health analysis has surfaced a [strange piece of code](https://sonarcloud.io/project/issues?id=mediawiki-extensions-Wikibase&open=AWt1uNEeBeEiCS_y_c0G&severities=MAJOR&statuses=OPEN&types=BUG): ```lang=php, name=MatchingTermsLookupSearchInteractor.php if ( count( $matchedTermIndexEntries ) > $limit ) { array_slice( $matchedTermIndexEntries, 0, $limit, true ); } ``` PHP's [array_slice](https://www.php.net/manual/en/function.array-slice.php) does not mutate its arguments but instead returns a value. That returned value is not used here, so something is wrong. * [x] Figure out what is going on. Do we actually have a bug here that can be somehow seen in production? * [x] Try to understand why there are no tests failing (are there none for that feature?) * [x] Fix it (either remove it if it is not used or fix it and write a test for it if it is an actual bug in prod)

The sonar code health analysis has surfaced a [strange piece of code](https://sonarcloud.io/project/issues?id=mediawiki-extensions-Wikibase&open=AWt1uNEeBeEiCS_y_c0G&severities=MAJOR&statuses=OPEN&types=BUG): ```lang=php, name=MatchingTermsLookupSearchInteractor.php if ( count( $matchedTermIndexEntries ) > $limit ) { array_slice( $matchedTermIndexEntries, 0, $limit, true ); } ``` PHP's [array_slice](https://www.php.net/manual/en/function.array-slice.php) does not mutate its arguments but instead returns a value. That returned value is not used here, so something is wrong. * [ * [x] Figure out what is going on. Do we actually have a bug here that can be somehow seen in production? * [ * [x] Try to understand why there are no tests failing (are there none for that feature?) * [ * [x] Fix it (either remove it if it is not used or fix it and write a test for it if it is an actual bug in prod)