Change Details

If a filter has af_throttled because it was triggered too often AND some of its action were automatically disabled, then on Special:AbuseFilter/xxx the message 'abusefilter-edit-throttled-warning' is shown, and on Special:AbuseFilter that filter's line will be coloured with red and the 'throttled' flag added. However, if a filter has af_throttled BUT no actions disabled, then on Special:AbuseFilter it'll still have a red line, but no warning is shown on the filter View since no actions were throttled. I'm not totally sure how to fix this: we could make some changes to the messages, e.g. show a slightly different one on ViewEdit if no actions were affected, or check for disabled actions on ViewList as well. But, actually, I wonder whether we should count for throttling filters which don't have any restricted action. Or maybe count them, but don't add the af_throttled flag? I have two examples for this behaviour, but they're both private filters and I'm not sure whether it would be fine to say which ones without changing the view policy.

If a filter has af_throttled = 1 because it was triggered too often AND some of its action were automatically disabled, then on Special:AbuseFilter/xxx the message 'abusefilter-edit-throttled-warning' is shown, and on Special:AbuseFilter that filter's line will be coloured with red and the 'throttled' flag added. However, if a filter has af_throttled BUT no actions disabled, then on Special:AbuseFilter it'll still have a red line, but no warning is shown on the filter View since no actions were throttled. I'm not totally sure how to fix this: we could make some changes to the messages, e.g. show a slightly different one on ViewEdit if no actions were affected, or check for disabled actions on ViewList as well. But, actually, I wonder whether we should count for throttling filters which don't have any restricted action. Or maybe count them, but don't add the af_throttled flag? I have two examples for this behaviour, but they're both private filters and I'm not sure whether it would be fine to say which ones without changing the view policy.

If a filter has af_throttled = 1 because it was triggered too often AND some of its action were automatically disabled, then on Special:AbuseFilter/xxx the message 'abusefilter-edit-throttled-warning' is shown, and on Special:AbuseFilter that filter's line will be coloured with red and the 'throttled' flag added. However, if a filter has af_throttled BUT no actions disabled, then on Special:AbuseFilter it'll still have a red line, but no warning is shown on the filter View since no actions were throttled. I'm not totally sure how to fix this: we could make some changes to the messages, e.g. show a slightly different one on ViewEdit if no actions were affected, or check for disabled actions on ViewList as well. But, actually, I wonder whether we should count for throttling filters which don't have any restricted action. Or maybe count them, but don't add the af_throttled flag? I have two examples for this behaviour, but they're both private filters and I'm not sure whether it would be fine to say which ones without changing the view policy.