Change Details

I've been doing some consolidation work in the MobileApp repo while breaking ground on the new Page Content Service CSS endpoint. For this initial iteration the goal is just to get the bundle behind an endpoint so the apps can have their styles updated agilely. Further, we want to serve the same bundle to both apps if at all possible. I think this is achievable. Here are some open questions blocking additional consolidation: * Historically we've had different 'pagestyles' and 'preview' modules, with the 'preview' modules effectively just omitting a couple of modules. Does anyone know why we omit certain modules for previews? Could we just use the same CSS bundle in all cases? * Is the Android app team willing to drop some of its unique CSS? ** Can the CSS loading animation for loading sections be dropped, since article loading state is already indicated by a native ProgressBar? *** I've submitted patches for this: https://gerrit.wikimedia.org/r/#/c/417516/ (Android), https://gerrit.wikimedia.org/r/#/c/417514/ (MobileApp) ** Only the Android app hides IPAs; the iOS app and mobile web don't. Is this behavior essential to the Android app experience or can it be dropped? ** frwiki hacks (to resolve T167307) *** This is a copypaste snippet from frwiki Common.css should eventually be removed when we integrate wiki-specific Common.css *** In the meantime is there any reason it couldn't live directly in the app repo and be separately linked from index.html?

I've been doing some consolidation work in the MobileApp repo while breaking ground on the new Page Content Service CSS endpoint. For this initial iteration the goal is just to get the bundle behind an endpoint so the apps can have their styles updated agilely. Further, we want to serve the same bundle to both apps if at all possible. I think this is achievable. Here are some open questions blocking additional consolidation: * Historically we've had different 'pagestyles' and 'preview' modules, with the 'preview' modules effectively just omitting some styles. Does anyone know why we omit certain modules for previews? Could we just use the same CSS bundle in all cases? * Is the Android app team willing to drop some of its unique CSS? ** Can the CSS loading animation for loading sections be dropped, since article loading state is already indicated by a native ProgressBar? *** I've submitted patches for this: https://gerrit.wikimedia.org/r/#/c/417516/ (Android), https://gerrit.wikimedia.org/r/#/c/417514/ (MobileApp) ** Only the Android app hides IPAs; the iOS app and mobile web don't. Is this behavior essential to the Android app experience or can it be dropped? ** frwiki hacks (to resolve T167307) *** This is a copypaste snippet from frwiki Common.css should eventually be removed when we integrate wiki-specific Common.css *** In the meantime is there any reason it couldn't live directly in the app repo and be separately linked from index.html?

I've been doing some consolidation work in the MobileApp repo while breaking ground on the new Page Content Service CSS endpoint. For this initial iteration the goal is just to get the bundle behind an endpoint so the apps can have their styles updated agilely. Further, we want to serve the same bundle to both apps if at all possible. I think this is achievable. Here are some open questions blocking additional consolidation: * Historically we've had different 'pagestyles' and 'preview' modules, with the 'preview' modules effectively just omitting a couple of modulessome styles. Does anyone know why we omit certain modules for previews? Could we just use the same CSS bundle in all cases? * Is the Android app team willing to drop some of its unique CSS? ** Can the CSS loading animation for loading sections be dropped, since article loading state is already indicated by a native ProgressBar? *** I've submitted patches for this: https://gerrit.wikimedia.org/r/#/c/417516/ (Android), https://gerrit.wikimedia.org/r/#/c/417514/ (MobileApp) ** Only the Android app hides IPAs; the iOS app and mobile web don't. Is this behavior essential to the Android app experience or can it be dropped? ** frwiki hacks (to resolve T167307) *** This is a copypaste snippet from frwiki Common.css should eventually be removed when we integrate wiki-specific Common.css *** In the meantime is there any reason it couldn't live directly in the app repo and be separately linked from index.html?