Change Details

Currently, AbuseFilter's Throttle consequence implements the user throttle mode by doing: `$identifier = $user->getId();`. This creates a shared throttle rule for all IP addresses, which doesn't look like a good thing to do. I propose to use `$identifier = $user->getName();` instead, which will not change anything for logged in users, but will treat each separate IP editor separately. Other solution for that is to use `user,ip` throttling mode, which has also its own side effects (namely de-facto exempting users with highly dynamic ranges). @Daimona would like to see this discussed in Phab first, which makes sense. So, what do you all think?

Currently, AbuseFilter's Throttle consequence implements the user throttle mode by doing: `$identifier = $user->getId();`. This creates a shared throttle rule for all IP addresses, which doesn't look like a good thing to do. I propose to use `$identifier = $user->getName();` instead, which will not change anything for logged in users, but will treat each separate IP editor separately. Other solution for that is to use `user,ip` throttling mode, which has also its own side effects (namely de-facto exempting users with highly dynamic ranges). @Daimona would like to see this discussed in Phab first, which makes sense. So, what do you all think? ==== List of filters throttling only by `user` | wiki | filter_id | ----- | ----- | acewiki | 1 | acewiki | 2 | acewiki | 3 | arwiki | 96 | arwiki | 131 | arwiki | 175 | azwiki | 26 | azwikibooks | 1 | betawikiversity | 6 | bgwiki | 20 | cawikinews | 15 | commonswiki | 60 | commonswiki | 110 | commonswiki | 190 | cswiki | 14 | cswiki | 44 | dewiki | 31 | dewiki | 253 | dewiki | 287 | dewiki | 294 | dewiki | 302 | dewiki | 304 | dewiki | 326 | dewiki | 327 | dewiktionary | 41 | elwiki | 27 | enwiki | 68 | enwiki | 242 | enwiki | 643 | enwiki | 806 | enwiki | 826 | enwiki | 1135 | enwiki | 1158 | enwikibooks | 22 | enwikibooks | 51 | enwikiquote | 25 | enwikiversity | 15 | enwikivoyage | 18 | enwiktionary | 44 | enwiktionary | 83 | enwiktionary | 133 | eswiki | 121 | eswikinews | 21 | eswikivoyage | 24 | fawiki | 17 | fawiki | 43 | fawiki | 106 | fawiki | 167 | fawiki | 169 | fawiki | 185 | fawiki | 186 | fawiki | 187 | fawiki | 192 | fawiki | 205 | fawikiquote | 31 | fiwiki | 75 | fiwiki | 163 | frwiki | 214 | frwiki | 283 | frwiki | 326 | frwiki | 332 | frwikiquote | 2 | frwikivoyage | 6 | hewiki | 9 | hewiki | 77 | hewiki | 78 | hewiki | 86 | idwiki | 5 | idwiki | 6 | idwiki | 34 | idwiki | 76 | idwiki | 96 | itwiki | 91 | itwiki | 320 | itwiki | 465 | itwikivoyage | 14 | jawiki | 163 | mrwiki | 12 | mrwiki | 51 | mrwiki | 58 | mrwiki | 144 | plwiki | 49 | plwikisource | 9 | plwikisource | 10 | ptwiki | 2 | rowiki | 35 | rowiki | 38 | rowiki | 52 | rowiki | 53 | rowiki | 61 | ruwiki | 16 | ruwiki | 26 | scowiki | 9 | scowiki | 11 | shwiki | 2 | simplewiki | 49 | simplewiki | 75 | skwiki | 26 | skwiki | 38 | srwiki | 38 | thwiki | 18 | thwiki | 74 | thwiki | 76 | thwiki | 79 | thwiki | 108 | trwiki | 103 | ukwiki | 29 | ukwikivoyage | 29 | viwiki | 4 | viwiki | 31 | viwiki | 86 | viwiki | 102 | viwiki | 104 | wikidatawiki | 129 | zh_yuewiki | 8 | zh_yuewiki | 33 | zhwiki | 8 | zhwiki | 24 | zhwiki | 43 | zhwiki | 44 | zhwiki | 91 | zhwiki | 216 | zhwiki | 317 | zhwiki | 318 | zhwiki | 326 (generated on 2021-08-30 by @Urbanecm via code from P17103)

Currently, AbuseFilter's Throttle consequence implements the user throttle mode by doing: `$identifier = $user->getId();`. This creates a shared throttle rule for all IP addresses, which doesn't look like a good thing to do. I propose to use `$identifier = $user->getName();` instead, which will not change anything for logged in users, but will treat each separate IP editor separately. Other solution for that is to use `user,ip` throttling mode, which has also its own side effects (namely de-facto exempting users with highly dynamic ranges). @Daimona would like to see this discussed in Phab first, which makes sense. So, what do you all think? ==== List of filters throttling only by `user` | wiki | filter_id | ----- | ----- | acewiki | 1 | acewiki | 2 | acewiki | 3 | arwiki | 96 | arwiki | 131 | arwiki | 175 | azwiki | 26 | azwikibooks | 1 | betawikiversity | 6 | bgwiki | 20 | cawikinews | 15 | commonswiki | 60 | commonswiki | 110 | commonswiki | 190 | cswiki | 14 | cswiki | 44 | dewiki | 31 | dewiki | 253 | dewiki | 287 | dewiki | 294 | dewiki | 302 | dewiki | 304 | dewiki | 326 | dewiki | 327 | dewiktionary | 41 | elwiki | 27 | enwiki | 68 | enwiki | 242 | enwiki | 643 | enwiki | 806 | enwiki | 826 | enwiki | 1135 | enwiki | 1158 | enwikibooks | 22 | enwikibooks | 51 | enwikiquote | 25 | enwikiversity | 15 | enwikivoyage | 18 | enwiktionary | 44 | enwiktionary | 83 | enwiktionary | 133 | eswiki | 121 | eswikinews | 21 | eswikivoyage | 24 | fawiki | 17 | fawiki | 43 | fawiki | 106 | fawiki | 167 | fawiki | 169 | fawiki | 185 | fawiki | 186 | fawiki | 187 | fawiki | 192 | fawiki | 205 | fawikiquote | 31 | fiwiki | 75 | fiwiki | 163 | frwiki | 214 | frwiki | 283 | frwiki | 326 | frwiki | 332 | frwikiquote | 2 | frwikivoyage | 6 | hewiki | 9 | hewiki | 77 | hewiki | 78 | hewiki | 86 | idwiki | 5 | idwiki | 6 | idwiki | 34 | idwiki | 76 | idwiki | 96 | itwiki | 91 | itwiki | 320 | itwiki | 465 | itwikivoyage | 14 | jawiki | 163 | mrwiki | 12 | mrwiki | 51 | mrwiki | 58 | mrwiki | 144 | plwiki | 49 | plwikisource | 9 | plwikisource | 10 | ptwiki | 2 | rowiki | 35 | rowiki | 38 | rowiki | 52 | rowiki | 53 | rowiki | 61 | ruwiki | 16 | ruwiki | 26 | scowiki | 9 | scowiki | 11 | shwiki | 2 | simplewiki | 49 | simplewiki | 75 | skwiki | 26 | skwiki | 38 | srwiki | 38 | thwiki | 18 | thwiki | 74 | thwiki | 76 | thwiki | 79 | thwiki | 108 | trwiki | 103 | ukwiki | 29 | ukwikivoyage | 29 | viwiki | 4 | viwiki | 31 | viwiki | 86 | viwiki | 102 | viwiki | 104 | wikidatawiki | 129 | zh_yuewiki | 8 | zh_yuewiki | 33 | zhwiki | 8 | zhwiki | 24 | zhwiki | 43 | zhwiki | 44 | zhwiki | 91 | zhwiki | 216 | zhwiki | 317 | zhwiki | 318 | zhwiki | 326 (generated on 2021-08-30 by @Urbanecm via code from P17103)