Change Details

Now that {T145231} has been fixed, the TextExtracts API can now respond to requests for large numbers of characters/sentences without falling over. This is great (!) but we should define/enforce limits for both in order to limit memory consumption. == AC * Define sensible limits for the number of characters/sentences that can be requested. * Make the API respond with an error if the client request exceeds those limits. == Strawman limits Characters: 1050 – Page Previews, for example, requests 525. Sentences: 10 – This'll easily satisfy the official Android app, which requests 2, and RESTBase, which [[ https://github.com/wikimedia/restbase/blob/master/v1/summary.yaml#L118 | requests 5 ]] for page summaries..

Now that {T145231} has been fixed, the TextExtracts API can now respond to requests for large numbers of characters/sentences without falling over. This is great (!) but we should define/enforce limits for both in order to limit memory consumption. == AC * Define sensible limits for the number of characters/sentences that can be requested. * Make the API respond with an error if the client request exceeds those limits. == Strawman limits Characters: 1050 – Page Previews, for example, requests 525. Sentences: 10 – This'll easily satisfy the official Android app, which requests 2, and RESTBase, which [[ https://github.com/wikimedia/restbase/blob/master/v1/summary.yaml#L118 | requests 5 ]] for page summaries.

Now that {T145231} has been fixed, the TextExtracts API can now respond to requests for large numbers of characters/sentences without falling over. This is great (!) but we should define/enforce limits for both in order to limit memory consumption. == AC * Define sensible limits for the number of characters/sentences that can be requested. * Make the API respond with an error if the client request exceeds those limits. == Strawman limits Characters: 1050 – Page Previews, for example, requests 525. Sentences: 10 – This'll easily satisfy the official Android app, which requests 2, and RESTBase, which [[ https://github.com/wikimedia/restbase/blob/master/v1/summary.yaml#L118 | requests 5 ]] for page summaries..