Change Details

**Steps to replicate the issue** (include links if applicable): * Create a wish or focus area * Make note of the page ID (can be found on the `?action=info` page) * Verify the entity is in the `communityrequests_entities` table, ala `SELECT * FROM communityrequests_entities WHERE cr_page = :pageid` * Delete the page **What happens?**: The row is still in the `communityrequests_entities` table **What should have happened instead?**: It shouldn't be there. **Other information** (browser name/version, screenshots, etc.): We are supposedly deleting the data with the `PageDeleteComplete` hook – the code is [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CommunityRequests/+/5935ace8be6bc59507a210832f52fe05c26e0ce9/includes/HookHandler/CommunityRequestsHooks.php#249 | there ]] – it just doesn't appear to work. In my testing, the hook handler is not called at all. In case it effects the implementation, note we also need to ensure deletion of data happens when deleting pages via Extension:Translate, which is done via job queue (`DeleteTranslatableBundleJob`).

**Steps to replicate the issue** (include links if applicable): * Create a wish or focus area with a vote-able status * Add a vote, verify it is visible * Make note of the entity page ID (can be found at i.e. `Community Wishlist/W1?action=info`) * Verify the entity is in the `communityrequests_entities` table, ala `SELECT * FROM communityrequests_entities WHERE cr_page = :pageid` * Delete the page **What happens?**: The row is still in the `communityrequests_entities` table, and the `/Votes` subpage still exists. **What should have happened instead?**: The corresponding rows in our tables should be deleted, as should the /Votes page. **Other information** (browser name/version, screenshots, etc.): We are supposedly deleting the data with the `PageDeleteComplete` hook – the code is [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CommunityRequests/+/5935ace8be6bc59507a210832f52fe05c26e0ce9/includes/HookHandler/CommunityRequestsHooks.php#249 | there ]] – it just doesn't appear to work. In my testing, the hook handler is not called at all. In case it effects the implementation, note we also need to ensure deletion of data happens when deleting pages via Extension:Translate, which is done via job queue (`DeleteTranslatableBundleJob`).

**Steps to replicate the issue** (include links if applicable): * Create a wish or focus area with a vote-able status * Add a vote, verify it is visible * Make note of the entity page ID (can be found on the `at i.e. `Community Wishlist/W1?action=info` page) * Verify the entity is in the `communityrequests_entities` table, ala `SELECT * FROM communityrequests_entities WHERE cr_page = :pageid` * Delete the page **What happens?**: The row is still in the `communityrequests_entities` table, and the `/Votes` subpage still exists. **What should have happened instead?**: ItThe corresponding rows in our tables shouldn't be thered be deleted, as should the /Votes page. **Other information** (browser name/version, screenshots, etc.): We are supposedly deleting the data with the `PageDeleteComplete` hook – the code is [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CommunityRequests/+/5935ace8be6bc59507a210832f52fe05c26e0ce9/includes/HookHandler/CommunityRequestsHooks.php#249 | there ]] – it just doesn't appear to work. In my testing, the hook handler is not called at all. In case it effects the implementation, note we also need to ensure deletion of data happens when deleting pages via Extension:Translate, which is done via job queue (`DeleteTranslatableBundleJob`).