Change Details

=== Steps to reproduce # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) # Press the browser forward button (now at Barack_Obama#/search) # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) OR: # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Remove a watchlist star (or add and remove a star). # Press the browser back button (now at Barack_Obama) === Expected results - Search overlay is dismissed when URL fragment isn't `#/search` === Actual results - Search overlay persists until closed via the cross button or browser refresh == Acceptance criteria [] If the address bar has #/search and I refresh the page, SearchOverlay will remain present [] If SearchOverlay is open and I click browser back button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If SearchOverlay is open and I click X (close) button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If I am on page A, I do a search, click a search result B and click back I should be taken to the article A without the search open [] If I am on page D, click back and land on page C, open the SearchOverlay, close the search overlay, click Forward, I should be taken to page D (not the SearchOverlay) [] If I click the search input, click browser back and click browser forward the SearchOverlay should show (unless there is an article forwards in the browser history, which should take priority) === Environments observed **Browser Version: ** - Chromium v64.0.3282.167 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit) - Firefox v58.0.2 (64-bit) **OS Version:** - Ubuntu v17.10 **Device Model:** - Desktop **Device Language:** - English also affecting mobile web: iOS (Safari & Chrome), Android (Chrome)

=== Steps to reproduce # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) # Press the browser forward button (now at Barack_Obama#/search) # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) OR: # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Remove a watchlist star (or add and remove a star). # Press the browser back button (now at Barack_Obama) === Expected results - Search overlay is dismissed when URL fragment isn't `#/search` === Actual results - Search overlay persists until closed via the cross button or browser refresh == Acceptance criteria [] ~~If the address bar has #/search and I refresh the page, SearchOverlay will remain present~~ [] If SearchOverlay is open and I click browser back button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If SearchOverlay is open and I click X (close) button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If I am on page A, I do a search, click a search result B and click back I should be taken to the article A without the search open [] If I am on page D, click back and land on page C, open the SearchOverlay, close the search overlay, click Forward, I should be taken to page D (not the SearchOverlay) [] If I click the search input, click browser back and click browser forward the SearchOverlay should show (unless there is an article forwards in the browser history, which should take priority) === Environments observed **Browser Version: ** - Chromium v64.0.3282.167 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit) - Firefox v58.0.2 (64-bit) **OS Version:** - Ubuntu v17.10 **Device Model:** - Desktop **Device Language:** - English also affecting mobile web: iOS (Safari & Chrome), Android (Chrome)

=== Steps to reproduce # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) # Press the browser forward button (now at Barack_Obama#/search) # Tap search and press "a" (now at Barack_Obama#/search) # Press the browser back button (now at Barack_Obama) OR: # Go to https://en.m.wikipedia.org/wiki/Barack_Obama # Tap search and press "a" (now at Barack_Obama#/search) # Remove a watchlist star (or add and remove a star). # Press the browser back button (now at Barack_Obama) === Expected results - Search overlay is dismissed when URL fragment isn't `#/search` === Actual results - Search overlay persists until closed via the cross button or browser refresh == Acceptance criteria [] ~~If the address bar has #/search and I refresh the page, SearchOverlay will remain present~~ [] If SearchOverlay is open and I click browser back button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If SearchOverlay is open and I click X (close) button, hide the SearchOverlay and ensure `#/search` is removed from URL [] If I am on page A, I do a search, click a search result B and click back I should be taken to the article A without the search open [] If I am on page D, click back and land on page C, open the SearchOverlay, close the search overlay, click Forward, I should be taken to page D (not the SearchOverlay) [] If I click the search input, click browser back and click browser forward the SearchOverlay should show (unless there is an article forwards in the browser history, which should take priority) === Environments observed **Browser Version: ** - Chromium v64.0.3282.167 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit) - Firefox v58.0.2 (64-bit) **OS Version:** - Ubuntu v17.10 **Device Model:** - Desktop **Device Language:** - English also affecting mobile web: iOS (Safari & Chrome), Android (Chrome)