Change Details

From T224821#5229782 > The phan `-m checkstyle` options is to make it generate a checkstyle report to stdout which is a XML document. That is why some characters end up being escaped. > > I think the intent was to have Jenkins to process the checkstyle report and generate a nice / human friendly version out of it. That is show down in the console log when the plugin tries to find a file `log/phan-issues` for the report: > > 00:01:34.272 [CHECKSTYLE] Searching for all files in /srv/jenkins-workspace/workspace/mwext-php70-phan-docker that match the pattern log/phan-issues > 00:01:34.272 [CHECKSTYLE] No files found. Configuration error? > > The file is not found! > > The `phan-issues` log file comes from MediaWiki core wrapper `tests/phan/bin/phan` but it is only used for a few repositories (mediawiki/extensions/Wikibase is one of them). When Phan is recent enough (most case), we should be able to pass it a file to write to: `-m checkstyle -o phan-issues`. And the file should probably be more explicitly named. Currently it is just emitted to the console log. The report should be written to a file and we should then have the CI job to process the checkstyle report.

The Phan jobs emit a checkstyle report which is barely readable for humans. We could use the Jenkins publisher report but it is not that helpful since: * we point users to the console log * it shows a diff compared to the previous build which is an entirely unrelated commit / repository. Seems nicer to just print a text report (the default) with colors.

From T224821#5229782The Phan jobs emit a checkstyle report which is barely readable for humans. We could use the Jenkins publisher report but it is not that helpful since: > The phan `-m checkstyle` options is to make it generate a checkstyle report to stdout which is a XML document. That is why some characters end up being escaped.* we point users to the console log > > I think the intent was to have Jenkins to process the checkstyle report and generate a nice / human friendly version out of it. That is show down in the console log when the plugin tries to find a file `log/phan-issues` for the report: > > 00:01:34.272 [CHECKSTYLE] Searching for all files in /srv/jenkins-workspace/workspace/mwext-php70-phan-docker that match the pattern log/phan-issues > 00:01:34.272 [CHECKSTYLE] No files found. Configuration error? > > The file is not found! > > The `phan-issues` log file comes from MediaWiki core wrapper `tests/phan/bin/phan` but it is only used for a few repositories (mediawiki/extensions/Wikibase is one of them). When Phan is recent enough (most case), we should be able to pass it a file to write to: `-m checkstyle -o phan-issues`. And the file should probably be more explicitly named. Currently it is just emitted to the console log. The report should be written to a file and we should then have the CI job to process the checkstyle report* it shows a diff compared to the previous build which is an entirely unrelated commit / repository. Seems nicer to just print a text report (the default) with colors.