Change Details

I'm proposing to refactor the code that handles database cloning for unit tests, see I37b8e801. Jenkins tests on that change "sometimes" fail due to EchoDiscussionParserTest: 18:09:14 1) EchoDiscussionParserTest::testGenerateEventsForRevision with data set #0 (637638133, 637637213, 'Cwobeel', 'en', array('[[User:{{{1}}}|{{<includeonly...clude>'), 'UTPage', array(array('mention', 'Cwobeel'))) 18:09:14 MWException: CAS update failed on user_touched for user ID '2' (read from slave); the version of the user to be saved is older than the current version. 18:09:14 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/user/User.php:3793 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Echo/tests/phpunit/DiscussionParserTest.php:149 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:214 I'm not sure how to try and reproduce this locally. Also, this fails often, but not always, so it seems timing related. Any hints?

I'm proposing to refactor the code that handles database cloning for unit tests, see I37b8e801. Jenkins tests on that change "sometimes" fail due to EchoDiscussionParserTest: 18:09:14 1) EchoDiscussionParserTest::testGenerateEventsForRevision with data set #0 (637638133, 637637213, 'Cwobeel', 'en', array('[[User:{{{1}}}|{{<includeonly...clude>'), 'UTPage', array(array('mention', 'Cwobeel'))) 18:09:14 MWException: CAS update failed on user_touched for user ID '2' (read from slave); the version of the user to be saved is older than the current version. 18:09:14 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/user/User.php:3793 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Echo/tests/phpunit/DiscussionParserTest.php:149 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:214 I'm not sure how to try and reproduce this locally. Also, this fails often, but not always, so it seems timing related. This is blocking work on the proposed dependency injection infrastructure.

I'm proposing to refactor the code that handles database cloning for unit tests, see I37b8e801. Jenkins tests on that change "sometimes" fail due to EchoDiscussionParserTest: 18:09:14 1) EchoDiscussionParserTest::testGenerateEventsForRevision with data set #0 (637638133, 637637213, 'Cwobeel', 'en', array('[[User:{{{1}}}|{{<includeonly...clude>'), 'UTPage', array(array('mention', 'Cwobeel'))) 18:09:14 MWException: CAS update failed on user_touched for user ID '2' (read from slave); the version of the user to be saved is older than the current version. 18:09:14 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/includes/user/User.php:3793 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Echo/tests/phpunit/DiscussionParserTest.php:149 18:09:14 /mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/tests/phpunit/MediaWikiTestCase.php:214 I'm not sure how to try and reproduce this locally. Also, this fails often, but not always, so it seems timing related. Any hints? This is blocking work on the proposed dependency injection infrastructure.