Searching is suffering from various UI regressions. While usable, there are problems with the spinner showing when it shouldn't and the search in pages feature being squished:
{F27322777, size=full}
There are similar breakages in the media viewer:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein#/media/File%3AEinstein_1921_by_F_Schmutzer_-_restoration.jpg
and minor breakages in the languages overlay and visual editor overlay (T210640):
{F27322819}
= Post morterm
The regressions were due to some problems in the inheritance chain which meant the incorrect class on Overlays was being set. I've documented them in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/476404 Overlays should respect inheritance chain when passing up options
This did not make the train so no SWATs are needed
= QA steps
We should visit every single possible overlay in mobile and verify that nothing looks odd about them. Please test this on the **BETA CLUSTER**
Ideally this should happen after the completion of T209007
The overlays to check are
[] Search
[] Editor (wikitext)
[] Editor (VisualEditor)
[] ImageOverlay (click an image)
[] NotificationsOverlay (click the bell icon in top right when logged in)
[] Page issues overlay (visit https://en.wikipedia.beta.wmflabs.org/wiki/This_page_also_has_issues)
[] Languages
[] Categories (logged in beta visit https://en.wikipedia.beta.wmflabs.org/wiki/CategoryTest)
[] Talk (logged in bottom of page) - make sure you can also add talk topics and commeent on existing talk topics