Change Details

From code review session on 2nd August: To make it clearer where and how the mw.user object literal is used, we believe it might be better to pass this parameter into Views as a parameter rather than using an M.require statement. The mw.user uses MobileWebSearchLogger, TalkOverlay, EditorOverlayBase, BetaOptinPanel

From code review session on 2nd August: To make it clearer where and how the mw.user object literal or M.require( 'mobile.startup/user' ) is used inside a class, we believe it might be better to pass this parameter into Views as a parameter rather than using an M.require statement. = Developer notes * mw.user is used in MobileWebSearchLogger, TalkOverlay, EditorOverlayBase, BetaOptinPanel * The `mobile.startup/user` module is used in TalkOverlay.js, TalkSectionOverlay.js, Watchstar.js, WatchstarPageList.js, schemaMobileWebMainMenuClickTracking.js, EditorOverlayBase.js The required MobileFrontend changes is illustrated in [[ https://gerrit.wikimedia.org/r/372077 | this patch ]]: A change will need to be made in MinervaNeue beforehand to pass the user parameter to the above classes.

From code review session on 2nd August: To make it clearer where and how the mw.user object literal or M.require( 'mobile.startup/user' ) is usedd inside a class, we believe it might be better to pass this parameter into Views as a parameter rather than using an M.require statement. = Developer notes The* mw.user is usesd in MobileWebSearchLogger, TalkOverlay, EditorOverlayBase, BetaOptinPanel * The `mobile.startup/user` module is used in TalkOverlay.js, TalkSectionOverlay.js, Watchstar.js, WatchstarPageList.js, schemaMobileWebMainMenuClickTracking.js, EditorOverlayBase.js The required MobileFrontend changes is illustrated in [[ https://gerrit.wikimedia.org/r/372077 | this patch ]]: A change will need to be made in MinervaNeue beforehand to pass the user parameter to the above classes.