Change Details

MinervaTemplate::getTemplateData sets a template data key pageactionshtml. This should be migrated to SkinMinerva::getTemplateData When making this change we want to remove the use of TemplateParser inside SkinMinerva. Instead {{>PageActions}} will be used directly in the template. # TODO [x] MinervaTemplate::getPageActionsHtml should be removed, in its place SkinMinerva::getPageActionsData will be created. # QA steps For AMC, anonymous users and non-AMC confirm: 1) there are no UI regressions at the top of the page (where the edit icon/language icon is) 2) the talk tabs are present at the top of the page (AMC only) on the following pages: * https://en.m.wikipedia.org/wiki/User:Jdlrobson * https://en.m.wikipedia.org/wiki/User talk:Jdlrobson * https://en.m.wikipedia.org/wiki/Agostino_Giustiniani * https://en.m.wikipedia.org/wiki/Talk:Agostino_Giustiniani # Developer notes - You'll likely need to set a private variable in SkinMinerva::prepareMenus to make this work - The components folder is likely to cause some problems given the non-standard way it loads partials.

MinervaTemplate::getTemplateData sets a template data key pageactionshtml. This should be migrated to SkinMinerva::getTemplateData When making this change we want to remove the use of TemplateParser inside SkinMinerva. Instead {{>PageActions}} will be used directly in the template. # TODO [x] MinervaTemplate::getPageActionsHtml should be removed, in its place SkinMinerva::getPageActionsData will be created. # QA steps For AMC, anonymous users and non-AMC confirm: 1) there are no UI regressions at the top of the page (where the edit icon/language icon is) 2) the talk tabs are present at the top of the page (AMC only) on the following pages: * https://en.m.wikipedia.org/wiki/User:Jdlrobson (NOTE: talk tabs should shown for all users) * https://en.m.wikipedia.org/wiki/User_talk:Jdlrobson (NOTE: talk tabs should shown for all users) * https://en.m.wikipedia.org/wiki/Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users) * https://en.m.wikipedia.org/wiki/Talk:Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users) # Developer notes - You'll likely need to set a private variable in SkinMinerva::prepareMenus to make this work - The components folder is likely to cause some problems given the non-standard way it loads partials.

MinervaTemplate::getTemplateData sets a template data key pageactionshtml. This should be migrated to SkinMinerva::getTemplateData When making this change we want to remove the use of TemplateParser inside SkinMinerva. Instead {{>PageActions}} will be used directly in the template. # TODO [x] MinervaTemplate::getPageActionsHtml should be removed, in its place SkinMinerva::getPageActionsData will be created. # QA steps For AMC, anonymous users and non-AMC confirm: 1) there are no UI regressions at the top of the page (where the edit icon/language icon is) 2) the talk tabs are present at the top of the page (AMC only) on the following pages: * https://en.m.wikipedia.org/wiki/User:Jdlrobson (NOTE: talk tabs should shown for all users) * https://en.m.wikipedia.org/wiki/User _talk:Jdlrobsonobson (NOTE: talk tabs should shown for all users) * https://en.m.wikipedia.org/wiki/Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users) * https://en.m.wikipedia.org/wiki/Talk:Agostino_Giustiniani (NOTE: article/talk tab should not show to anonymous users) # Developer notes - You'll likely need to set a private variable in SkinMinerva::prepareMenus to make this work - The components folder is likely to cause some problems given the non-standard way it loads partials.