Change Details

[TweetANew](https://www.mediawiki.org/wiki/Extension:TweetANew) extension [will be pushed](https://gerrit.wikimedia.org/r/#/c/400128/) with [PHP Code Sniffer](https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer) which is a new thing for this repository. It consists of really bloated code, any CS guidelines almost doesn't exist here. I've added this Code Sniffer along with a bunch of `<exclude>`s to make patch pass Jenkins, but we need to improve that legacy code style with MediaWiki standard. These are the sniffs that need to be fixed and removed: - [ ] `Generic.Arrays.DisallowLongArraySyntax.Found` - [ ] `Generic.ControlStructures.InlineControlStructure.NotAllowed` - [ ] `Generic.Files.LineLength.TooLong` - [ ] `Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma` - [ ] `Generic.PHP.NoSilencedErrors.Discouraged` - [ ] `Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed` - [ ] `MediaWiki.AlternativeSyntax.AlternativeSyntax.AlternativeSyntax` - [ ] `MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic` - [ ] `MediaWiki.Commenting.FunctionComment.MissingParamComment` - [ ] `MediaWiki.Commenting.FunctionComment.MissingParamName` - [ ] `MediaWiki.Commenting.FunctionComment.MissingParamTag` - [ ] `MediaWiki.Commenting.FunctionComment.MissingReturn` - [ ] `MediaWiki.Commenting.FunctionComment.NotShortBoolParam` - [ ] `MediaWiki.Commenting.FunctionComment.ParamNameNoMatch` - [ ] `MediaWiki.Commenting.FunctionComment.SpacingBeforeParamType` - [ ] `MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse` - [ ] `MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse` - [ ] `MediaWiki.Files.ClassMatchesFilename.NotMatch` - [ ] `MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName` - [ ] `MediaWiki.WhiteSpace.DisallowEmptyLineFunctions.NoEmptyLine` - [ ] `MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment` - [ ] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis` - [ ] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis` - [ ] `PSR2.Classes.PropertyDeclaration.Underscore` - [ ] `Squiz.Classes.ValidClassName.NotCamelCaps` - [ ] `Squiz.Operators.ValidLogicalOperators.NotAllowed`

[TweetANew](https://www.mediawiki.org/wiki/Extension:TweetANew) extension [will be pushed](https://gerrit.wikimedia.org/r/#/c/400128/) with [PHP Code Sniffer](https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer) which is a new thing for this repository. It consists of really bloated code, any CS guidelines almost doesn't exist here. I've added this Code Sniffer along with a bunch of `<exclude>`s to make patch pass Jenkins, but we need to improve that legacy code style with MediaWiki standard. These are the sniffs that need to be fixed and removed: - [x] `Generic.Arrays.DisallowLongArraySyntax.Found` - [x] `Generic.ControlStructures.InlineControlStructure.NotAllowed` - [x] `Generic.Files.LineLength.TooLong` - [x] `Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma` - [x] `Generic.PHP.NoSilencedErrors.Discouraged` - [x] `Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed` - [x] `MediaWiki.AlternativeSyntax.AlternativeSyntax.AlternativeSyntax` - [x] `MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic` - [x] `MediaWiki.Commenting.FunctionComment.MissingParamComment` - [x] `MediaWiki.Commenting.FunctionComment.MissingParamName` - [x] `MediaWiki.Commenting.FunctionComment.MissingParamTag` - [x] `MediaWiki.Commenting.FunctionComment.MissingReturn` - [x] `MediaWiki.Commenting.FunctionComment.NotShortBoolParam` - [x] `MediaWiki.Commenting.FunctionComment.ParamNameNoMatch` - [x] `MediaWiki.Commenting.FunctionComment.SpacingBeforeParamType` - [x] `MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse` - [x] `MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse` - [x] `MediaWiki.Files.ClassMatchesFilename.NotMatch` - [x] `MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName` - [x] `MediaWiki.WhiteSpace.DisallowEmptyLineFunctions.NoEmptyLine` - [x] `MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment` - [x] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis` - [x] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis` - [x] `PSR2.Classes.PropertyDeclaration.Underscore` - [x] `Squiz.Classes.ValidClassName.NotCamelCaps` - [x] `Squiz.Operators.ValidLogicalOperators.NotAllowed`

[TweetANew](https://www.mediawiki.org/wiki/Extension:TweetANew) extension [will be pushed](https://gerrit.wikimedia.org/r/#/c/400128/) with [PHP Code Sniffer](https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer) which is a new thing for this repository. It consists of really bloated code, any CS guidelines almost doesn't exist here. I've added this Code Sniffer along with a bunch of `<exclude>`s to make patch pass Jenkins, but we need to improve that legacy code style with MediaWiki standard. These are the sniffs that need to be fixed and removed: - [ - [x] `Generic.Arrays.DisallowLongArraySyntax.Found` - [ - [x] `Generic.ControlStructures.InlineControlStructure.NotAllowed` - [ - [x] `Generic.Files.LineLength.TooLong` - [ - [x] `Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma` - [ - [x] `Generic.PHP.NoSilencedErrors.Discouraged` - [ - [x] `Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed` - [ - [x] `MediaWiki.AlternativeSyntax.AlternativeSyntax.AlternativeSyntax` - [ - [x] `MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic` - [ - [x] `MediaWiki.Commenting.FunctionComment.MissingParamComment` - [ - [x] `MediaWiki.Commenting.FunctionComment.MissingParamName` - [ - [x] `MediaWiki.Commenting.FunctionComment.MissingParamTag` - [ - [x] `MediaWiki.Commenting.FunctionComment.MissingReturn` - [ - [x] `MediaWiki.Commenting.FunctionComment.NotShortBoolParam` - [ - [x] `MediaWiki.Commenting.FunctionComment.ParamNameNoMatch` - [ - [x] `MediaWiki.Commenting.FunctionComment.SpacingBeforeParamType` - [ - [x] `MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse` - [ - [x] `MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse` - [ - [x] `MediaWiki.Files.ClassMatchesFilename.NotMatch` - [ - [x] `MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName` - [ - [x] `MediaWiki.WhiteSpace.DisallowEmptyLineFunctions.NoEmptyLine` - [ - [x] `MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment` - [ - [x] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis` - [ - [x] `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis` - [ - [x] `PSR2.Classes.PropertyDeclaration.Underscore` - [ - [x] `Squiz.Classes.ValidClassName.NotCamelCaps` - [ - [x] `Squiz.Operators.ValidLogicalOperators.NotAllowed`