Change Details

As a user without translator rights, it is possible to insert text from the translation helpers, even though the translation editor text area is read-only. Steps to reproduce: 1. Go to URL as anonymous user 2. Click "Admin" in row 6-7. Observed: I. Translation editor opens II. Messaging is "You need permission to translate messages." III. Textarea is read-only. 3. In the translation helper area, click "Use as translation" below "Beheer" Observed: IV. String is inserted in editor, which remains read-only. Expected: V. Nothing should happen (or something else, but at least no string insertion in the editor). -------------------------- **Version**: master **Severity**: trivial **URL**: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-translate-0-all&language=fy&filter=!translated&action=translate

As a user without translator rights, it is possible to insert text from the translation helpers, even though the translation editor text area is read-only. Steps to reproduce: 1. Go to https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-translate-0-all&language=fy&filter=!translated&action=translate as anonymous user 2. Click a simple message Observed: I. Translation editor opens II. Messaging is "You need permission to translate messages." III. Textarea is read-only. 3. In the translation helper area, click "Use as translation" below "Beheer" (or whatever is suggested) Observed: IV. String is inserted in editor, which remains read-only. Expected: V. Nothing should happen (or something else, but at least no string insertion in the editor). One way to fix this would be to update `suggestionAdder` in `ext.translate.editor.helpers.js` to check whether the textarea is readonly.

As a user without translator rights, it is possible to insert text from the translation helpers, even though the translation editor text area is read-only. Steps to reproduce: 1. Go to URLhttps://translatewiki.net/w/i.php?title=Special:Translate&group=ext-translate-0-all&language=fy&filter=!translated&action=translate as anonymous user 2. Click "Admin" in row 6-7.a simple message Observed: I. Translation editor opens II. Messaging is "You need permission to translate messages." III. Textarea is read-only. 3. In the translation helper area, click "Use as translation" below "Beheer" (or whatever is suggested) Observed: IV. String is inserted in editor, which remains read-only. Expected: V. Nothing should happen (or something else, but at least no string insertion in the editor). -------------------------- **Version**: master **Severity**: trivial **URL**: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-translate-0-all&language=fy&filter=!translated&action=translateOne way to fix this would be to update `suggestionAdder` in `ext.translate.editor.helpers.js` to check whether the textarea is readonly.