We should update extensions for the removal of OOjs UI core icon pack
Basically, grep all of our code for every icon name removed here: https://gerrit.wikimedia.org/r/#/c/238324/2/src/themes/mediawiki/icons.json then make sure that the appropriate new icon pack is being loaded. Otherwise icons will disappear in various places.
Quick reference on the new homes for each of the icons:
* `interactions`: add, advanced, cancel, check, close, ellipsis, help, search, settings
* `editing-advanced`: code
* `editing-core`: redo, undo
* `alerts`: alert, comment, notice
* `movement`: collapse, expand, next, previous
* `layout`: menu
* `content`: history, info, tag, window
* //Removed//: circle (no replacement), remove (use 'trash' from the 'moderation' pack instead)
Potential violators – a human needs to verify that all this code has the necessary dependencies
(List generated by searching for `\b(setIcon\(|icon:|mw-ui-icon-|icon\b.{0,10}=>).{0,10}\b(add|advanced|alert|cancel|check|circle|close|code|collapse|comment|ellipsis|expand|help|history|info|menu|next|notice|previous|redo|remove|search|settings|tag|undo|window)\b` and some manual pruning.
# {icon check color=green} MediaWiki #
[x] core/includes/widget/SearchInputWidget.php – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki/mediawiki.filewarning.js – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki/page/gallery-slideshow.js – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
[x] core/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.HighlightColorPickerWidget.js
[x] core/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
[x] core/resources/src/mediawiki.special/mediawiki.special.apisandbox.js – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki.widgets/mw.widgets.SearchInputWidget.js – https://gerrit.wikimedia.org/r/356777
[x] core/resources/src/mediawiki.widgets.datetime/CalendarWidget.js – https://gerrit.wikimedia.org/r/356777
# Wikimedia-deployed extensions #
[x] extensions/CentralNotice/resources/infrastructure/ext.centralNotice.adminUi.bannerSequence.js –
https://gerrit.wikimedia.org/r/#/c/356509/
[x] extensions/Cite/modules/ve-cite/ve.ui.MWReferenceDialog.js – https://gerrit.wikimedia.org/r/357004
[x] extensions/ContentTranslation/modules/source/ext.cx.source.selector.js
[x] extensions/ContentTranslation/modules/tools/mw.cx.tools.ReferenceTool.js
[x] extensions/ContentTranslation/modules/tools/mw.cx.tools.TargetLinkTool.js
[x] extensions/ContentTranslation/modules/ui/mw.cx.ui.Categories.js
[x] extensions/ContentTranslation/modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
[x] extensions/ContentTranslation/modules/ui/widgets/mw.cx.ui.PublishSettingsWidget.js
[x] extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php
[x] extensions/Echo/modules/ui/mw.echo.ui.BundleNotificationItemWidget.js – https://gerrit.wikimedia.org/r/#/c/356514/
[x] extensions/Echo/modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js – https://gerrit.wikimedia.org/r/#/c/356514/
[x] extensions/Echo/modules/ui/mw.echo.ui.FooterNoticeWidget.js
[x] extensions/Echo/modules/ui/mw.echo.ui.NotificationBadgeWidget.js – https://gerrit.wikimedia.org/r/#/c/356514/
[x] extensions/Echo/modules/ui/mw.echo.ui.NotificationItemWidget.js
[x] extensions/Echo/modules/ui/mw.echo.ui.PaginationWidget.js – https://gerrit.wikimedia.org/r/#/c/356514/
[x] extensions/Echo/modules/ui/mw.echo.ui.SpecialHelpMenuWidget.js
[x] extensions/Flow/handlebars/flow_header_detail.partial.handlebars
[x] extensions/Flow/handlebars/flow_load_more.partial.handlebars
[x] extensions/Flow/handlebars/flow_moderation_actions_list.partial.handlebars
[x] extensions/Flow/handlebars/flow_post_actions.partial.handlebars
[x] extensions/Flow/handlebars/flow_topic_moderation_flag.partial.handlebars
[x] extensions/Flow/handlebars/flow_topic_titlebar.partial.handlebars
[x] extensions/Flow/handlebars/flow_topic_titlebar_content.partial.handlebars
[x] extensions/Flow/modules/engine/misc/mw-ui.modal.js
[ ] extensions/Graph/modules/ve-graph/ve.ui.MWGraphDialog.js
[ ] extensions/Kartographer/modules/dialog/dialog.js
[ ] extensions/Kartographer/modules/dialog-sidebar/sidebar.js
[ ] extensions/Kartographer/modules/ve-maps/ve.ui.MWMapsDialog.js
[ ] extensions/MobileFrontend/resources/mobile.categories.overlays/CategoryLookupInputWidget.js
[x] extensions/RevisionSlider/modules/ext.RevisionSlider.HelpButtonView.js
[x] extensions/RevisionSlider/modules/ext.RevisionSlider.init.js
[x] extensions/RevisionSlider/modules/ext.RevisionSlider.SliderArrowView.js
[x] extensions/TemplateData/modules/ext.templateDataGenerator.ui.tdDialog.js – https://gerrit.wikimedia.org/r/357007
[x] extensions/TemplateData/modules/widgets/ext.templateDataGenerator.paramWidget.js – https://gerrit.wikimedia.org/r/357007
[ ] extensions/TwoColConflict/includes/TwoColConflictPage.php – https://gerrit.wikimedia.org/r/357211
[x] extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js – https://gerrit.wikimedia.org/r/356504
[x] extensions/UploadWizard/resources/details/uw.DescriptionDetailsWidget.js – https://gerrit.wikimedia.org/r/356504
[x] extensions/UploadWizard/resources/mw.UploadWizardDetails.js – https://gerrit.wikimedia.org/r/357009
[x] extensions/UploadWizard/resources/ui/steps/uw.ui.Details.js – https://gerrit.wikimedia.org/r/357009
[x] extensions/VisualEditor/lib/ve/demos/ve/demo.minimal.js
[x] extensions/VisualEditor/lib/ve/demos/ve/ve.demo.init.js
[x] extensions/VisualEditor/lib/ve/src/ce/ve.ce.BranchNode.js
[x] extensions/VisualEditor/lib/ve/src/init/sa/ve.init.sa.MobileTarget.js
[x] extensions/VisualEditor/lib/ve/src/init/sa/ve.init.sa.Target.js
[x] extensions/VisualEditor/lib/ve/src/init/ve.init.Target.js
[x] extensions/VisualEditor/lib/ve/src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
[x] extensions/VisualEditor/lib/ve/src/ui/dialogs/ve.ui.ProgressDialog.js
[x] extensions/VisualEditor/lib/ve/src/ui/ve.ui.DebugBar.js
[x] extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js – https://gerrit.wikimedia.org/r/#/c/356593/
[x] extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/elements/ve.ui.MWExpandableErrorElement.js
[x] extensions/VisualEditor/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/pages/ve.ui.MWCategoriesPage.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWInternalLinkAnnotationWidget.js – https://gerrit.wikimedia.org/r/356779
[x] extensions/VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWMediaInfoFieldWidget.js – https://gerrit.wikimedia.org/r/356779
[ ] extensions/WikibaseQualityConstraints/docs/user.js
# Other #
[ ] extensions/BlueSpiceExtendedSearch/src/MediaWiki/Specials/SearchCenter.php
[ ] extensions/BlueSpiceExtensions/VisualEditor/VisualEditor.class.php
[ ] extensions/CollaborationKit/includes/content/CollaborationHubContent.php
[ ] extensions/CollaborationKit/modules/ext.CollaborationKit.hubtheme.js
[ ] extensions/CollaborationKit/modules/ext.CollaborationKit.list.members.js
[ ] extensions/CollaborationKit/modules/ext.CollaborationKit.list.ui.js
[ ] extensions/FileAnnotations/resources/src/FileAnnotationEditor.js
[ ] extensions/FileAnnotations/resources/src/FileAnnotator.js
[ ] extensions/GoogleLogin/javascripts/specialpages/ext.GoogleLogin.specialManage.js
[ ] extensions/LanguageTool/modules/ext.LanguageToolDialog.js
[ ] extensions/Newsletter/includes/content/NewsletterContent.php
[ ] extensions/PerformanceInspector/modules/ext.PerformanceInspector.view.js
[ ] extensions/PerformanceInspector/modules/collectors/ext.PerformanceInspector.modulescss.js