Change Details

Sometimes, undeletions can cause parent revisions to become broken, as a consequence of actually preserving the existing value (ar_parent_id) in the archive table (T183375). For example, the rev_parent_id for [[https://en.wikipedia.org/w/index.php?title=Lisa_Maxwell_(actress)&oldid=136808840|revision 136808840]] on the English Wikipedia is 87419000, which is a deleted revision ID. We need to find out how we can prevent the tragedy of broken parent revisions before we can worry about T185167 in the general case. Three possible ways to solve this include: * When a revision is being inserted with the "insertRevisionOn" function in the RevisionStore class, check the provided parent ID for the RevisionRecord object and see if it is a non-existent or deleted revision. If it is, then it will be treated as if it were not provided at all, and the result of the "getPreviousRevisionId" function will be used instead. Also, when a page B is being deleted, check to see if there is another page A with a revision whose rev_parent_id field is a revision from page B that is being deleted, and update the field for each such revision. Finally, make the deleteOldRevisions.php maintenance script change the rev_parent_id field for every (selected) page's latest revision (which will become the only one) to zero. * When a revision is being undeleted, apply the "domino effect" by forcing the parent revision to be undeleted as well. Also, when the parent revision for a revision from page A is a revision from another page B and page B is being deleted, force page A to be deleted as well. Finally, get rid of the deleteOldRevisions.php maintenance script entirely. * When an undeletion would result in a broken parent revision, forgo the undeletion and just display an error instead. Also, when the parent revision for a revision from page A is a revision from another page B, don't allow page B to be deleted until page A is deleted first. Finally, as with the second solution above, get rid of the deleteOldRevisions.php maintenance script entirely. Regardless of how this is solved, we will need to fix the existing revisions with broken parent revisions with a maintenance script (T186280).

Sometimes, undeletions can cause parent revisions to become broken, as a consequence of actually preserving the existing value (ar_parent_id) in the archive table (T183375). For example, the rev_parent_id for [[https://en.wikipedia.org/w/index.php?title=Lisa_Maxwell_(actress)&oldid=136808840|revision 136808840]] on the English Wikipedia is 87419000, which is a deleted revision ID. We need to find out how we can prevent the tragedy of broken parent revisions before we can worry about T185167 in the general case. Three possible ways to solve this include: * When a revision is being inserted with the "insertRevisionOn" function in the RevisionStore class, check the provided parent ID for the RevisionRecord object and see if it is a non-existent or deleted revision. If it is, then it will be treated as if it were not provided at all, and the result of the "getPreviousRevisionId" function will be used instead. Also, when a page B is being deleted, check to see if there is another page A with a revision whose rev_parent_id field is a revision from page B that is being deleted, and update the field for each such revision. Finally, make the deleteOldRevisions.php maintenance script change the rev_parent_id field for each (selected) page's latest revision (which will become the only one) to zero. * When a revision is being undeleted, apply the "domino effect" by forcing the parent revision to be undeleted as well. Also, when the parent revision for a revision from page A is a revision from another page B and page B is being deleted, force page A to be deleted as well. Finally, get rid of the deleteOldRevisions.php maintenance script entirely. * When an undeletion would result in a broken parent revision, forgo the undeletion and just display an error instead. Also, when the parent revision for a revision from page A is a revision from another page B, don't allow page B to be deleted until page A is deleted first. Finally, as with the second solution above, get rid of the deleteOldRevisions.php maintenance script entirely. Regardless of how this is solved, we will need to fix the existing revisions with broken parent revisions with a maintenance script (T186280).

Sometimes, undeletions can cause parent revisions to become broken, as a consequence of actually preserving the existing value (ar_parent_id) in the archive table (T183375). For example, the rev_parent_id for [[https://en.wikipedia.org/w/index.php?title=Lisa_Maxwell_(actress)&oldid=136808840|revision 136808840]] on the English Wikipedia is 87419000, which is a deleted revision ID. We need to find out how we can prevent the tragedy of broken parent revisions before we can worry about T185167 in the general case. Three possible ways to solve this include: * When a revision is being inserted with the "insertRevisionOn" function in the RevisionStore class, check the provided parent ID for the RevisionRecord object and see if it is a non-existent or deleted revision. If it is, then it will be treated as if it were not provided at all, and the result of the "getPreviousRevisionId" function will be used instead. Also, when a page B is being deleted, check to see if there is another page A with a revision whose rev_parent_id field is a revision from page B that is being deleted, and update the field for each such revision. Finally, make the deleteOldRevisions.php maintenance script change the rev_parent_id field for everyeach (selected) page's latest revision (which will become the only one) to zero. * When a revision is being undeleted, apply the "domino effect" by forcing the parent revision to be undeleted as well. Also, when the parent revision for a revision from page A is a revision from another page B and page B is being deleted, force page A to be deleted as well. Finally, get rid of the deleteOldRevisions.php maintenance script entirely. * When an undeletion would result in a broken parent revision, forgo the undeletion and just display an error instead. Also, when the parent revision for a revision from page A is a revision from another page B, don't allow page B to be deleted until page A is deleted first. Finally, as with the second solution above, get rid of the deleteOldRevisions.php maintenance script entirely. Regardless of how this is solved, we will need to fix the existing revisions with broken parent revisions with a maintenance script (T186280).