In dozens and dozens of repos we've got the eslint rules over-ride of `"dot-notation": [ "error", { "allowKeywords": true } ]`.
This dates from when we allowed ES3-only browsers to use our code, with ES5 methods poly-filled as needed. Consequently, any time people used a property named the same as a ES3-future-reserved-but-dropped-in-ES5 keyword, they had to escape it (//e.g.// `foo.super` would break an ES3 browser, so one had to use `foo['super']`). However, we now require ES5-compatible parsing in all browsers, so it's no longer needed.
At this point it's just been cargo-culted around the codebases. Let's burn it with fire.
Gerrit searches:
[[ https://gerrit.wikimedia.org/r/#/q/bug:T210552 | bug:T210552 ]]
[[ https://gerrit.wikimedia.org/r/#/q/bug:T210552+is:open | bug:T210552 is:open ]]
----
Initial hit-list from [[https://codesearch.wmflabs.org/deployed/?q=dot-notation&i=nope]] :
[x] MediaWiki
[x] VE standalone
[x] OOUI
[ ] extensions / AdvancedSearch
[ ] extensions / ArticleCreationWorkflow
[ ] extensions / BetaFeatures
[ ] extensions / CentralAuth
[ ] extensions / Cite
[ ] extensions / Citoid
[ ] extensions / CodeEditor
[ ] extensions / CodeMirror
[ ] extensions / ContentTranslation
[x] extensions / Echo
[x] extensions / Flow
[ ] extensions / Graph
[ ] extensions / Kartographer
[ ] extensions / Math
[x] extensions / MobileFrontend
[ ] extensions / MultimediaViewer
[ ] extensions / Newsletter
[ ] extensions / PageViewInfo
[ ] extensions / PerformanceInspector
[ ] extensions / Popups
[ ] extensions / ProofreadPage
[ ] extensions / QuickSurveys
[ ] extensions / RevisionSlider
[ ] extensions / Score
[ ] extensions / SyntaxHighlight_GeSHi
[ ] extensions / TemplateData
[ ] extensions / TemplateWizard
[ ] extensions / TwoColConflict
[ ] extensions / UniversalLanguageSelector
[ ] extensions / UploadWizard
[x] extensions / VisualEditor
[ ] extensions / Wikibase
[ ] extensions / WikibaseLexeme
[ ] extensions / WikibaseMediaInfo
[ ] extensions / WikibaseQualityConstraints
[ ] extensions / WikiEditor
[ ] extensions / wikihiero
[ ] skins / MinervaNeue