Change Details

**Steps to replicate the issue** (include links if applicable): * Create topics with curly brackets (e.g. [[https://zh.wikipedia.org/wiki/User_talk:%E9%AD%94%E7%90%B4/%E8%AE%A8%E8%AE%BA%E9%A1%B5%E6%B2%99%E7%9B%92/%E8%8A%B1%E6%8B%AC%E5%8F%B7 | w:zh:User talk:魔琴/讨论页沙盒/花括号 ]] * Copy the DiscussionTool anchor. * Construct a Special:GoToComment link with the anchor. **What happens?**: It fails complaining about invalid characters inside the special page title. The complain is correct, yet the creation of anchors/fragments with curly brackets breaks the ability to use GoToComment links to refer to comments inside such topics. **What should have happened instead?**: GoToComment should either accept the parameter despite having invalid characters, or DiscussionTools should skip invalid title character when creating anchors/fragments. **Software version** (on `Special:Version` page; skip for WMF-hosted wikis like Wikipedia): wmf, zhwiki **Other information** (browser name/version, screenshots, etc.): * This affected #convenient-discussions's ability to generate GoToComment wikilink syntaxes, as the gadget attempts to feed a GoToComment special page title with curly brackets in it to `mw.Title.newFromText`, which is designed to reject any titles containing anything outside of `wgLegalTitleChars`. ** That also shows a lack of null-checking on [[ https://github.com/jwbth/convenient-discussions/blob/e7731f8513ef4f642f13e4b7ff64b2706212c1fc/src/controller.js#L1256 | CD/src/controller.js#L1256 ]], but that's another story. * I haven't tested whether other non-`wgLegalTitleChars` characters would cause the same issue, but I guess at least some would. Fixes should look up for `wgLegalTitleChars` instead of hard-coding curly brackets.

**Steps to replicate the issue** (include links if applicable): * Create topics with curly brackets (e.g. [[https://zh.wikipedia.org/wiki/User_talk:%E9%AD%94%E7%90%B4/%E8%AE%A8%E8%AE%BA%E9%A1%B5%E6%B2%99%E7%9B%92/%E8%8A%B1%E6%8B%AC%E5%8F%B7 | w:zh:User talk:魔琴/讨论页沙盒/花括号 ]] * Copy the DiscussionTool anchor. * Construct a Special:GoToComment link with the anchor. **What happens?**: It fails complaining about invalid characters inside the special page title. The complain is correct, yet the creation of anchors/fragments with curly brackets breaks the ability to use GoToComment links to refer to comments inside such topics. **What should have happened instead?**: GoToComment should either accept the parameter despite having invalid characters, or DiscussionTools should skip invalid title character when creating anchors/fragments. **Software version** (on `Special:Version` page; skip for WMF-hosted wikis like Wikipedia): wmf, zhwiki **Other information** (browser name/version, screenshots, etc.): * This affected #convenient-discussions's ability to generate GoToComment wikilink syntaxes, as the gadget attempts to feed a GoToComment special page title with curly brackets in it to `mw.Title.newFromText`, which is designed to reject any titles containing anything outside of `wgLegalTitleChars`. ([[https://github.com/jwbth/convenient-discussions/blob/e7731f8513ef4f642f13e4b7ff64b2706212c1fc/src/pageRegistry.js#L55 | CD/src/pageRegistry.js#L55 ]]) ** That also shows a lack of null-checking on [[ https://github.com/jwbth/convenient-discussions/blob/e7731f8513ef4f642f13e4b7ff64b2706212c1fc/src/controller.js#L1256 | CD/src/controller.js#L1256 ]], but that's another story. * I haven't tested whether other non-`wgLegalTitleChars` characters would cause the same issue, but I guess at least some would. Fixes should look up for `wgLegalTitleChars` instead of hard-coding curly brackets.

**Steps to replicate the issue** (include links if applicable): * Create topics with curly brackets (e.g. [[https://zh.wikipedia.org/wiki/User_talk:%E9%AD%94%E7%90%B4/%E8%AE%A8%E8%AE%BA%E9%A1%B5%E6%B2%99%E7%9B%92/%E8%8A%B1%E6%8B%AC%E5%8F%B7 | w:zh:User talk:魔琴/讨论页沙盒/花括号 ]] * Copy the DiscussionTool anchor. * Construct a Special:GoToComment link with the anchor. **What happens?**: It fails complaining about invalid characters inside the special page title. The complain is correct, yet the creation of anchors/fragments with curly brackets breaks the ability to use GoToComment links to refer to comments inside such topics. **What should have happened instead?**: GoToComment should either accept the parameter despite having invalid characters, or DiscussionTools should skip invalid title character when creating anchors/fragments. **Software version** (on `Special:Version` page; skip for WMF-hosted wikis like Wikipedia): wmf, zhwiki **Other information** (browser name/version, screenshots, etc.): * This affected #convenient-discussions's ability to generate GoToComment wikilink syntaxes, as the gadget attempts to feed a GoToComment special page title with curly brackets in it to `mw.Title.newFromText`, which is designed to reject any titles containing anything outside of `wgLegalTitleChars`. ([[https://github.com/jwbth/convenient-discussions/blob/e7731f8513ef4f642f13e4b7ff64b2706212c1fc/src/pageRegistry.js#L55 | CD/src/pageRegistry.js#L55 ]]) ** That also shows a lack of null-checking on [[ https://github.com/jwbth/convenient-discussions/blob/e7731f8513ef4f642f13e4b7ff64b2706212c1fc/src/controller.js#L1256 | CD/src/controller.js#L1256 ]], but that's another story. * I haven't tested whether other non-`wgLegalTitleChars` characters would cause the same issue, but I guess at least some would. Fixes should look up for `wgLegalTitleChars` instead of hard-coding curly brackets.