Change Details

Scrubbing elements on template pages [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L163 | MobileFormatter::filterContent ]] can cause confusion to editors. For example https://hu.m.wikipedia.org/wiki/Sablon:%C3%9Ajpest_FC_keret which features a navbox and no other HTML shows as an empty page! = Acceptance criteria [] Do not apply the MobileFormatter transformation to content in the template namespace. To do this we will update the logic in [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L201 | the hook ]] that transforms the content. [] The new logic should be configurable so we can exclude other namespaces in future. We'll add a config variable called wgMFMobileFormatterNamespaceBlacklist which should default to [ NS_TEMPLATE, NS_SPECIAL ]. This will allow us to add other namespaces easily if necessary. = Developer notes For extra points and kudos the isSpecialPage checks inside https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L180 should be no longer necessary as a result of this change. Good work!

Scrubbing elements on template pages [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L163 | MobileFormatter::filterContent ]] can cause confusion to editors. For example https://hu.m.wikipedia.org/wiki/Sablon:%C3%9Ajpest_FC_keret which features a navbox and no other HTML shows as an empty page! = Acceptance criteria [] Do not apply the MobileFormatter transformation to content in the template namespace. To do this we will update the logic in [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L201 | the hook ]] that transforms the content. [] The new logic should be configurable so we can exclude other namespaces in future. We'll add a config variable called wgMFMobileFormatterNamespaceBlacklist which should default to [ NS_TEMPLATE, NS_SPECIAL ]. This will allow us to add other namespaces easily if necessary. = Developer notes For extra points and kudos the isSpecialPage checks inside https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L180 should be no longer necessary as a result of this change. Please remove this code in a follow up to your change. Good work! = Google Code in @Jdlrobson will help mentor this.

Scrubbing elements on template pages [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L163 | MobileFormatter::filterContent ]] can cause confusion to editors. For example https://hu.m.wikipedia.org/wiki/Sablon:%C3%9Ajpest_FC_keret which features a navbox and no other HTML shows as an empty page! = Acceptance criteria [] Do not apply the MobileFormatter transformation to content in the template namespace. To do this we will update the logic in [[ https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L201 | the hook ]] that transforms the content. [] The new logic should be configurable so we can exclude other namespaces in future. We'll add a config variable called wgMFMobileFormatterNamespaceBlacklist which should default to [ NS_TEMPLATE, NS_SPECIAL ]. This will allow us to add other namespaces easily if necessary. = Developer notes For extra points and kudos the isSpecialPage checks inside https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFormatter.php#L180 should be no longer necessary as a result of this change. Please remove this code in a follow up to your change. Good work! = Google Code in @Jdlrobson will help mentor this.