Change Details

== Background Currently night mode is only available on the mobile site. As we pivot to desktop, we need to make a key technical decision to decide how we approach configuration in Vector (T359606). Without this technical decision, we will not be able to maintain a consistent night mode across skins. In T357077 we explored different options for sharing code and created an [[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1009394/2/doc/adr/0004-code-sharing-between-vector-and-minerva.md | ADR to document our findings ]] - we now need to make a decision. == User story As a developer I need to understand how PHP code should be shared between Vector and Minerva to help me work on new feature requests. == Requirements See acceptance criteria. == Design No design needed. == Acceptance criteria [] The ADR is reviewed by the web team (developers, engineering manager and PM) and a decision is made on how we want to proceed [] The ADR should be marked as accepted. == Communication criteria - does this need an announcement or discussion? No == Sign off steps The decision is fed back into https://phabricator.wikimedia.org/T357077 and that ticket is made ready for estimation.

== Background Currently night mode is only available on the mobile site. As we pivot to desktop, we need to make a key technical decision to decide how we approach configuration in Vector (T359606). Without this technical decision, we will not be able to maintain a consistent night mode across skins. In T357077 we explored different options for sharing code and created an [[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1009394/2/doc/adr/0004-code-sharing-between-vector-and-minerva.md | ADR to document our findings ]] - we now need to make a decision. == User story As a developer I need to understand how PHP code should be shared between Vector and Minerva to help me work on new feature requests. == Requirements See acceptance criteria. == Design No design needed. == Acceptance criteria [x] The ADR is reviewed by the web team (developers, engineering manager and PM) and a decision is made on how we want to proceed [x] The ADR should be marked as accepted. == Communication criteria - does this need an announcement or discussion? No == Sign off steps The decision is fed back into https://phabricator.wikimedia.org/T357077 and that ticket is made ready for estimation.

== Background Currently night mode is only available on the mobile site. As we pivot to desktop, we need to make a key technical decision to decide how we approach configuration in Vector (T359606). Without this technical decision, we will not be able to maintain a consistent night mode across skins. In T357077 we explored different options for sharing code and created an [[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1009394/2/doc/adr/0004-code-sharing-between-vector-and-minerva.md | ADR to document our findings ]] - we now need to make a decision. == User story As a developer I need to understand how PHP code should be shared between Vector and Minerva to help me work on new feature requests. == Requirements See acceptance criteria. == Design No design needed. == Acceptance criteria [x] The ADR is reviewed by the web team (developers, engineering manager and PM) and a decision is made on how we want to proceed [x] The ADR should be marked as accepted. == Communication criteria - does this need an announcement or discussion? No == Sign off steps The decision is fed back into https://phabricator.wikimedia.org/T357077 and that ticket is made ready for estimation.