HomePhabricator

Transactions T115514 Change Details

Change Details

Old
New
Diff

in MagicWord::matchAndRemove(): ``` lang=php $text = preg_replace( $regex, '', $text ); ``` if preg_replace errors, it will log a warning and then return null. At some point, $text will be cast to an empty string. We should throw an exception if it errors, instead of silently failing. Related: https://wikitech.wikimedia.org/wiki/Incident_documentation/20151014-MediaWiki

in MagicWord::matchAndRemove(): ``` lang=php $text = preg_replace( $regex, '', $text ); ``` if preg_replace errors, it will log a warning and then return null. At some point, $text will be cast to an empty string. We should throw an exception if it errors, instead of silently failing. Related: https://wikitech.wikimedia.org/wiki/Incident_documentation/20151014-MediaWiki

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL