Change Details

Go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent I've populated the wiki with "active" collections so that we could test the infinite scrolling (which we are going to hit in production for sure) Scroll to the bottom and you will see that loading collections failed. This is most probably because https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.collections.list/CollectionsList.js#L105` there the collection type was renamed to 'recent' and not 'active' as you can see in the code.

This was fixed: ``` Go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent I've populated the wiki with "active" collections so that we could test the infinite scrolling (which we are going to hit in production for sure) Scroll to the bottom and you will see that loading collections failed. This is most probably because https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.collections.list/CollectionsList.js#L105` there the collection type was renamed to 'recent' and not 'active' as you can see in the code. ``` Now it is broken if you do the same thing but as an anonymous user. 1. As an anonymous user, go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent 2. Scroll down, pagination is broken. See comment for what to do: >>! In T103496#1399670, @Jhernandez wrote: > This is the pagination query being made: > http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&lstmode=allpublic&lstcontinue=20150623112529%7C451&lstminitems=4&list=lists&lstlimit=50&lsttitle=&lstprop=label%7Cdescription%7Cpublic%7Cimage%7Ccount%7Cowner > > And this is what it should be: > http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&lstmode=allpublic&lstcontinue=20150623112529%7C451&lstminitems=4&list=lists&lstlimit=50&&lstprop=label%7Cdescription%7Cpublic%7Cimage%7Ccount%7Cowner > > Note that it's missing `lstmode=allpublic` (because you need that if you're not logged in instead of always) and it shouldn't have `lsttitle=` (which does nothing but if present breaks `allpublic`). > > These involve touching: > > * this https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.collections.list/CollectionsList.js#L107 for adding `lstmode=allpublic` and > * this https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.api/CollectionsApi.js#L192 for not including `lsttitle` if not present instead of setting it to null. > > Herp darmit... this is important to fix on the next release (1.26wmf12 scheduled for 30 of June.

This was fixed: ``` Go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent I've populated the wiki with "active" collections so that we could test the infinite scrolling (which we are going to hit in production for sure) Scroll to the bottom and you will see that loading collections failed. This is most probably because https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.collections.list/CollectionsList.js#L105` there the collection type was renamed to 'recent' and not 'active' as you can see in the code. ``` Now it is broken if you do the same thing but as an anonymous user. 1. As an anonymous user, go to http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent 2. Scroll down, pagination is broken. See comment for what to do: >>! In T103496#1399670, @Jhernandez wrote: > This is the pagination query being made: > http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&lstmode=allpublic&lstcontinue=20150623112529%7C451&lstminitems=4&list=lists&lstlimit=50&lsttitle=&lstprop=label%7Cdescription%7Cpublic%7Cimage%7Ccount%7Cowner > > And this is what it should be: > http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&lstmode=allpublic&lstcontinue=20150623112529%7C451&lstminitems=4&list=lists&lstlimit=50&&lstprop=label%7Cdescription%7Cpublic%7Cimage%7Ccount%7Cowner > > Note that it's missing `lstmode=allpublic` (because you need that if you're not logged in instead of always) and it shouldn't have `lsttitle=` (which does nothing but if present breaks `allpublic`). > > These involve touching: > > * this https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.collections.list/CollectionsList.js#L107 for adding `lstmode=allpublic` and > * this https://github.com/wikimedia/mediawiki-extensions-Gather/blob/master/resources/ext.gather.api/CollectionsApi.js#L192 for not including `lsttitle` if not present instead of setting it to null. > > Herp darmit... this is important to fix on the next release (1.26wmf12 scheduled for 30 of June.