Change Details

## Context Ideal state: Extension:IPInfo shows baseline data from GeoLite2 and is supplemented by data from Spur (via #ipoid-service). ### Background In {T361884}, we removed the `$wgIPInfoGeoIP2EnterprisePath` from the `operations/mediawiki-config` repo, because we no longer want to use MaxMind Enterprise GeoIP2 data. The patch {bacf14164ad3403d18a2698f451bd52a50dd1f9f} also set `$wgIPInfoGeoLite2Prefix = '/usr/share/GeoIP/GeoLite2-';`. However, looking at this directory on a deployment server, we see: ``` [kharlan@deploy1002 ~]$ ls -al /usr/share/GeoIP/ | grep GeoLite2- -rw-r--r-- 1 root root 31893928 Nov 30 2020 GeoLite2-City.mmdb ``` In addition to missing the `-ASN` and `-Country` files, the `-City` file was last updated in 2020. The step we missed was updating calls to `operations/puppet`'s `geoip` module to specify that it should use GeoLite2 data and not GeoIP2 data. As a result, after deploying {bacf14164ad3403d18a2698f451bd52a50dd1f9f}, we started to receive reports from users (filed in an unrelated task, to further complicate matters) about not seeing data: T363118#9796877. That makes perfect sense as Country and ASN files are missing, and the City file was last updated four years ago. ## Proposal - Update `geoip.pp` to default to `$fetch_private` - Update callers to `puppetmaster::geoip()` to pass `false` instead of `true`, so that GeoLite2 dta is downloaded - Update `geoip.pp` to download the `-ASN` file ## Consequences - GeoLite2 data will be downloaded on app and API servers - GeoIP2 enterprise data will *no longer be downloaded* (an [[ https://wikimedia.slack.com/archives/C05FWANFT8X/p1712238553670819?thread_ts=1712072392.904389&cid=C05FWANFT8X | internal audit ]]by @ssingh and @Volans found that the only place this data is used is by Extension:IPInfo) - For now, I propose to leave the mechanism in place that allows for switching between GeoIP2 Enterprise and GeoLite2 data sources, in case it is needed in the future.

## Context Ideal state: Extension:IPInfo shows baseline data from GeoLite2 and is supplemented by data from Spur (via #ipoid-service). ### Background In {T361884}, we removed the `$wgIPInfoGeoIP2EnterprisePath` from the `operations/mediawiki-config` repo, because we no longer want to use MaxMind Enterprise GeoIP2 data. The patch {bacf14164ad3403d18a2698f451bd52a50dd1f9f} also set `$wgIPInfoGeoLite2Prefix = '/usr/share/GeoIP/GeoLite2-';`. However, looking at this directory on a deployment server, we see: ``` [kharlan@deploy1002 ~]$ ls -al /usr/share/GeoIP/ | grep GeoLite2- -rw-r--r-- 1 root root 31893928 Nov 30 2020 GeoLite2-City.mmdb ``` In addition to missing the `-ASN` and `-Country` files, the `-City` file was last downloaded in 2020 (on the deployment server, not sure about app servers) The step we missed was updating calls to `operations/puppet`'s `geoip` module to specify that it should download GeoLite2 data and not GeoIP2-Enterprise or GeoIP2 data. As a result, after deploying {bacf14164ad3403d18a2698f451bd52a50dd1f9f}, we started to receive reports from users (filed in an unrelated task, to further complicate matters) about not seeing data: T363118#9796877. That makes perfect sense as Country and ASN files are missing, and the City file was last updated four years ago. On May 30 we did a temporary revert of {bacf14164ad3403d18a2698f451bd52a50dd1f9f} via {429ebcfea028d7124a6c86c75060ebfe5ae5953f}. ## Proposal - Update the `operations/puppet` repo to download GeoLite2 data instead of GeoIP2-Enterprise data for IPInfo ## Consequences - GeoLite2 data will be downloaded on app and API servers - GeoIP2 enterprise data will *no longer be downloaded* (an [[ https://wikimedia.slack.com/archives/C05FWANFT8X/p1712238553670819?thread_ts=1712072392.904389&cid=C05FWANFT8X | internal audit ]]by @ssingh and @Volans found that the only place this data is used is by Extension:IPInfo)

## Context Ideal state: Extension:IPInfo shows baseline data from GeoLite2 and is supplemented by data from Spur (via #ipoid-service). ### Background In {T361884}, we removed the `$wgIPInfoGeoIP2EnterprisePath` from the `operations/mediawiki-config` repo, because we no longer want to use MaxMind Enterprise GeoIP2 data. The patch {bacf14164ad3403d18a2698f451bd52a50dd1f9f} also set `$wgIPInfoGeoLite2Prefix = '/usr/share/GeoIP/GeoLite2-';`. However, looking at this directory on a deployment server, we see: ``` [kharlan@deploy1002 ~]$ ls -al /usr/share/GeoIP/ | grep GeoLite2- -rw-r--r-- 1 root root 31893928 Nov 30 2020 GeoLite2-City.mmdb ``` In addition to missing the `-ASN` and `-Country` files, the `-City` file was last updatdownloaded in 2020. (on the deployment server, not sure about app servers) The step we missed was updating calls to `operations/puppet`'s `geoip` module to specify that it should usedownload GeoLite2 data and not GeoIP2-Enterprise or GeoIP2 data. As a result, after deploying {bacf14164ad3403d18a2698f451bd52a50dd1f9f}, we started to receive reports from users (filed in an unrelated task, to further complicate matters) about not seeing data: T363118#9796877. That makes perfect sense as Country and ASN files are missing, and the City file was last updated four years ago. On May 30 we did a temporary revert of {bacf14164ad3403d18a2698f451bd52a50dd1f9f} via {429ebcfea028d7124a6c86c75060ebfe5ae5953f}. ## Proposal - Update `geoip.pp` to default to `$fetch_private` - Update callers to `puppetmaster::geoip()` to pass `false` instead of `true`, so that GeoLite2 dta is downloaded - Update `geoip.pp` to download the `-ASN` filethe `operations/puppet` repo to download GeoLite2 data instead of GeoIP2-Enterprise data for IPInfo ## Consequences - GeoLite2 data will be downloaded on app and API servers - GeoIP2 enterprise data will *no longer be downloaded* (an [[ https://wikimedia.slack.com/archives/C05FWANFT8X/p1712238553670819?thread_ts=1712072392.904389&cid=C05FWANFT8X | internal audit ]]by @ssingh and @Volans found that the only place this data is used is by Extension:IPInfo) - For now, I propose to leave the mechanism in place that allows for switching between GeoIP2 Enterprise and GeoLite2 data sources, in case it is needed in the future.