Change Details

Mentioned by Tyler during a meeting: add the ability to diff images in Gerrit. There is a JavaScript plugin for it: https://gerrit.googlesource.com/plugins/image-diff https://github.com/GerritCodeReview/plugins_image-diff#image-diff That requires an inline build with `bazel build plugins/image-diff` to install the dependencies. The plugin can be tested against https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png which slightly change the Danmark Wikimedia logo: | Before | After |--|-- | {F37132303 size=full} | {F37132305 size=full} Which then let you see the differences (using cyan but that can be changed via a color picker): {F37132313 size=full} Make the images transparent to better see the diff: {F37132315 size=full} Or go in gray mode: {F37132318 size=full} There are some CSS glitches though but that do not seem too worrysome.

Mentioned by Tyler during a meeting: add the ability to diff images in Gerrit. There is a JavaScript plugin for it: https://gerrit.googlesource.com/plugins/image-diff https://github.com/GerritCodeReview/plugins_image-diff#image-diff That requires an inline build with `bazel build plugins/image-diff` to install the dependencies. The plugin can be tested against: [[ http://rsmbl.github.io/Resemble.js/ | Image from ResembleJS demo site ]]: https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/1051109/1..2/People.jpg https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png which slightly change the Danmark Wikimedia logo: | Before | After |--|-- | {F37132303 size=full} | {F37132305 size=full} Which then let you see the differences (using cyan but that can be changed via a color picker): {F37132313 size=full} Make the images transparent to better see the diff: {F37132315 size=full} Or go in gray mode: {F37132318 size=full} There are some CSS glitches though but that do not seem too worrysome.

Mentioned by Tyler during a meeting: add the ability to diff images in Gerrit. There is a JavaScript plugin for it: https://gerrit.googlesource.com/plugins/image-diff https://github.com/GerritCodeReview/plugins_image-diff#image-diff That requires an inline build with `bazel build plugins/image-diff` to install the dependencies. The plugin can be tested against : [[ http://rsmbl.github.io/Resemble.js/ | Image from ResembleJS demo site ]]: https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/1051109/1..2/People.jpg https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png which slightly change the Danmark Wikimedia logo: | Before | After |--|-- | {F37132303 size=full} | {F37132305 size=full} Which then let you see the differences (using cyan but that can be changed via a color picker): {F37132313 size=full} Make the images transparent to better see the diff: {F37132315 size=full} Or go in gray mode: {F37132318 size=full} There are some CSS glitches though but that do not seem too worrysome.