Change Details

The deployed solution to T300069 (showing the correct message title when viewing with qqx) has bad side-effects when the string '$/' exists in a banner. Fundraising banners that include regexes are throwing JS errors 'Unterminated regular expression literal' For example: https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0119_enWW_dsk_p1_lg_template&country=US Could we revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761486 or update it with a different delimiter that doesn't break regexes?

The deployed solution to T300069 (showing the correct message title when viewing with qqx) has bad side-effects when the string '$/' exists in a banner. Fundraising banners that include regexes are throwing JS errors 'Unterminated regular expression literal' For example: https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0119_enWW_dsk_p1_lg_template&country=US Could we revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761486 or update it with a different delimiter that doesn't break regexes? Note: It happens that Fundraising banners are not live right now. However, this also breaks banner previews, needed to test banners that are expected to go live shortly.

The deployed solution to T300069 (showing the correct message title when viewing with qqx) has bad side-effects when the string '$/' exists in a banner. Fundraising banners that include regexes are throwing JS errors 'Unterminated regular expression literal' For example: https://en.wikipedia.org/wiki/Wikipedia?banner=B2122_0119_enWW_dsk_p1_lg_template&country=US Could we revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761486 or update it with a different delimiter that doesn't break regexes? Note: It happens that Fundraising banners are not live right now. However, this also breaks banner previews, needed to test banners that are expected to go live shortly.