Change Details

>>! @Krinkle from https://gerrit.wikimedia.org/r/#/c/332973/ > Regardless, if not already, MMV should probably use a delegate handler on the content area. That way, it doesn't need to be informed about every single image. It also wouldn't need to select as many elements, looping through etc, and register so many event handlers. - Which can be fairly slow for a large document. At that point the public interface from MMV becomes reasonable for slideshow: Just ensure an element with the appropiate class exists in the content area, which is easy to satisfy in javascript if for some reason the image can't have that class already from the PHP output.

>>! @Krinkle from https://gerrit.wikimedia.org/r/#/c/332973/ > Regardless, if not already, MMV should probably use a delegate handler on the content area. That way, it doesn't need to be informed about every single image. It also wouldn't need to select as many elements, looping through etc, and register so many event handlers. - Which can be fairly slow on a large page. > >At that point the public interface from MMV becomes reasonable for slideshow: Just ensure an element with the appropiate class exists in the content area, which is easy to satisfy in javascript if for some reason the image can't have that class already from the PHP output.

>>! @Krinkle from https://gerrit.wikimedia.org/r/#/c/332973/ > Regardless, if not already, MMV should probably use a delegate handler on the content area. That way, it doesn't need to be informed about every single image. It also wouldn't need to select as many elements, looping through etc, and register so many event handlers. - Which can be fairly slow foron a large document. Atpage. > >At that point the public interface from MMV becomes reasonable for slideshow: Just ensure an element with the appropiate class exists in the content area, which is easy to satisfy in javascript if for some reason the image can't have that class already from the PHP output.